[Java] Add class checker API #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
added a commit
that referenced
this pull request
Aug 31, 2023
* add class check API * add white/black list based class checker * refine class checker * add missing header * refine documentation * refine documentation * add deserialize tests * refine security warning message
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add class checker API and white/black list based implementation.
Example:
{ Fury fury = Fury.builder().requireClassRegistration(false).build(); AllowListChecker checker = new AllowListChecker(AllowListChecker.CheckLevel.STRICT); fury.getClassResolver().setClassChecker(checker); checker.addListener(fury.getClassResolver()); assertThrows(InsecureException.class, () -> fury.serialize(new AllowListCheckerTest())); checker.allowClass("io.fury.*"); fury.serialize(new AllowListCheckerTest()); checker.disallowClass("io.fury.*"); assertThrows(InsecureException.class, () -> fury.serialize(new AllowListCheckerTest())); } { Fury fury = Fury.builder().requireClassRegistration(false).build(); AllowListChecker checker = new AllowListChecker(AllowListChecker.CheckLevel.WARN); fury.getClassResolver().setClassChecker(checker); checker.addListener(fury.getClassResolver()); fury.serialize(new AllowListCheckerTest()); checker.disallowClass("io.fury.*"); assertThrows(InsecureException.class, () -> fury.serialize(new AllowListCheckerTest())); } { AllowListChecker checker = new AllowListChecker(AllowListChecker.CheckLevel.STRICT); ThreadSafeFury fury = new ThreadLocalFury(classLoader -> { Fury f = Fury.builder().requireClassRegistration(false).withClassLoader(classLoader).build(); f.getClassResolver().setClassChecker(checker); checker.addListener(f.getClassResolver()); return f; }); checker.allowClass("io.fury.*"); fury.serialize(new AllowListCheckerTest()); checker.disallowClass("io.fury.*"); assertThrows(InsecureException.class, () -> fury.serialize(new AllowListCheckerTest())); }Related issue number
Closes #891
Check code requirements