Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi webapp #203

Merged
merged 33 commits into from
Mar 8, 2019
Merged

Support multi webapp #203

merged 33 commits into from
Mar 8, 2019

Conversation

QilongZhang
Copy link
Contributor

@QilongZhang QilongZhang added this to the 0.6.0 milestone Mar 5, 2019
@QilongZhang QilongZhang added the enhancement New feature or request label Mar 5, 2019
@QilongZhang QilongZhang mentioned this pull request Mar 5, 2019
Closed
@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 559

  • 17 of 94 (18.09%) changed or added relevant lines in 12 files are covered.
  • 75 unchanged lines in 30 files lost coverage.
  • Overall coverage decreased (-0.4%) to 49.113%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java 2 3 66.67%
sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkConfigs.java 0 2 0.0%
sofa-ark-plugin/web-ark-plugin/src/main/java/com/alipay/sofa/ark/web/embed/WebPluginActivator.java 0 4 0.0%
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/pipeline/HandleArchiveStage.java 4 11 36.36%
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizManagerServiceImpl.java 0 8 0.0%
sofa-ark-plugin/web-ark-plugin/src/main/java/com/alipay/sofa/ark/web/embed/tomcat/EmbeddedServerServiceImpl.java 0 9 0.0%
sofa-ark-plugin/web-ark-plugin/src/main/java/com/alipay/sofa/ark/web/embed/tomcat/ArkTomcatEmbeddedWebappClassLoader.java 0 46 0.0%
Files with Coverage Reduction New Missed Lines %
sofa-ark-parent/support/ark-springboot-integration/ark-common-springboot/src/main/java/com/alipay/sofa/ark/springboot/condition/OnArkEnabled.java 1 0.0%
sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/thread/CommonThreadPool.java 1 0.0%
sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/util/ClassLoaderUtils.java 1 0.0%
sofa-ark-parent/core/common/src/main/java/com/alipay/sofa/ark/common/util/FileUtils.java 1 0.0%
sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/argument/LaunchCommand.java 1 73.33%
sofa-ark-parent/support/ark-support-starter/src/main/java/com/alipay/sofa/ark/support/thread/LaunchRunner.java 1 51.35%
sofa-ark-parent/support/ark-support-starter/src/main/java/com/alipay/sofa/ark/support/listener/ArkTestNGAlterSuiteListener.java 1 91.18%
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/pipeline/StandardPipeline.java 1 87.88%
sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/service/plugin/PluginDeployServiceImpl.java 1 83.72%
sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/service/extension/ExtensionClass.java 1 0.0%
Totals Coverage Status
Change from base Build 553: -0.4%
Covered Lines: 1633
Relevant Lines: 3325
💛 - Coveralls

@QilongZhang QilongZhang requested a review from ujjboy March 8, 2019 03:39
ujjboy
ujjboy requested changes Mar 8, 2019
View reviewed changes
sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/web/EmbedServerService.java Outdated
* @author qilong.zql
* @since 0.6.0
*/
public interface EmbedServerService<T> {
Copy link
Member

@ujjboy ujjboy Mar 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换成 EmbeddedServerService 吧

...container/src/main/java/com/alipay/sofa/ark/container/service/biz/BizManagerServiceImpl.java Outdated
for (String bizName : bizRegistration.keySet()) {
for (String bizVersion : bizRegistration.get(bizName).keySet()) {
Biz biz = bizRegistration.get(bizName).get(bizVersion);
if (biz.getBizClassLoader().equals(classLoader)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use entrySet() and local variables for avoid get every time.

@ujjboy ujjboy merged commit bb82136 into sofastack:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

@straybirdzls straybirdzls straybirdzls approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@QilongZhang @coveralls @ujjboy @straybirdzls