Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFABoot add configuration com.alipay.sofa.healthcheck.enabled to disable readiness check #154

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

guanchao-yang
Copy link
Member

Motivation:

SOFABoot add configuration com.alipay.sofa.healthcheck.enabled to disable readiness check

Modification:

Add com.alipay.sofa.healthcheck.enabled configuration for disable readiness check.

Result:

Fixes #153

@guanchao-yang guanchao-yang added this to the 2.4.4 milestone Jul 28, 2018
@guanchao-yang guanchao-yang added the bug Something isn't working label Jul 28, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 377

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 65.575%

Changes Missing Coverage Covered Lines Changed/Added Lines %
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java 0 1 0.0%
Totals Coverage Status
Change from base Build 358: 0.6%
Covered Lines: 1362
Relevant Lines: 2077

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 28, 2018

Pull Request Test Coverage Report for Build 387

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 64 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.2%) to 65.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/endpoint/SofaBootVersionEndpoint.java 1 81.94%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthIndicatorCheckProcessor.java 1 70.45%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/startup/ReadinessCheckProcessor.java 1 75.86%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/service/helper/ReferenceRegisterHelper.java 2 76.19%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ServiceFactoryBean.java 2 69.44%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 3 0.0%
test-sofa-boot-starter/src/main/java/com/alipay/sofa/test/runner/SofaJUnit4Runner.java 3 56.67%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java 4 52.38%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/configuration/HealthCheckConfiguration.java 4 40.0%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/AfterHealthCheckCallbackProcessor.java 4 60.87%
Totals Coverage Status
Change from base Build 386: 0.2%
Covered Lines: 1454
Relevant Lines: 2233

💛 - Coveralls

@QilongZhang QilongZhang merged commit e030bb2 into sofastack:2.4.x Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants