Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch com.alipay.sofa.healthcheck.readiness to com.alipay.sofa.healthcheck in order to keep the configuration style #155

Merged
merged 2 commits into from
Jul 28, 2018

Conversation

guanchao-yang
Copy link
Member

Motivation:

Sync com.alipay.sofa.healthcheck.enabled configuration code

SOFABoot add configuration com.alipay.sofa.healthcheck.enabled to disable readiness check

Modification:

Add com.alipay.sofa.healthcheck.enabled configuration for disable readiness check.

Result:

Sync code fixes #154

… changed to com.alipay.sofa.healthcheck in order to keep the configuration style
@guanchao-yang guanchao-yang changed the title SOFABoot readiness check switch com.alipay.sofa.healthcheck.readiness changed to com.alipay.sofa.healthcheck in order to keep the configuration style Switch com.alipay.sofa.healthcheck.readiness to com.alipay.sofa.healthcheck in order to keep the configuration style Jul 28, 2018
@guanchao-yang guanchao-yang changed the title Switch com.alipay.sofa.healthcheck.readiness to com.alipay.sofa.healthcheck in order to keep the configuration style Switch com.alipay.sofa.healthcheck.readiness to com.alipay.sofa.healthcheck in order to keep the configuration style Jul 28, 2018
@coveralls
Copy link

coveralls commented Jul 28, 2018

Pull Request Test Coverage Report for Build 379

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 51 unchanged lines in 15 files lost coverage.
  • Overall coverage remained the same at 70.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/service/SofaBootReadinessCheckEndpoint.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/endpoint/SofaBootVersionEndpoint.java 1 85.42%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthIndicatorProcessor.java 1 81.13%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/callback/CloseApplicationContextCallBack.java 1 75.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/integration/activator/SofaRuntimeActivator.java 1 0.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/health/MultiApplicationHealthIndicator.java 2 56.25%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ServiceFactoryBean.java 2 66.67%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/service/helper/ReferenceRegisterHelper.java 3 72.73%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 3 0.0%
test-sofa-boot-starter/src/main/java/com/alipay/sofa/test/runner/SofaJUnit4Runner.java 3 56.67%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthCheckerProcessor.java 4 77.03%
Totals Coverage Status
Change from base Build 378: 0.0%
Covered Lines: 1547
Relevant Lines: 2182

💛 - Coveralls

@QilongZhang QilongZhang added this to In progress in v2.5.0 via automation Jul 28, 2018
@QilongZhang QilongZhang added this to the 2.5.0 milestone Jul 28, 2018
@QilongZhang QilongZhang added the optimization Code optimization label Jul 28, 2018
@QilongZhang QilongZhang merged commit 9123016 into sofastack:master Jul 28, 2018
v2.5.0 automation moved this from In progress to Done Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Code optimization
Projects
No open projects
v2.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants