Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sofa-version-maven-plugin for SOFABoot starters. #157

Merged
merged 2 commits into from
Jul 28, 2018

Conversation

caojie09
Copy link
Contributor

Add sofa-version-maven-plugin for SOFABoot starters.

@coveralls
Copy link

coveralls commented Jul 28, 2018

Pull Request Test Coverage Report for Build 385

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 15 files lost coverage.
  • Overall coverage remained the same at 64.935%

Files with Coverage Reduction New Missed Lines %
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/endpoint/SofaBootVersionEndpoint.java 1 81.94%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthIndicatorCheckProcessor.java 1 70.45%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/startup/ReadinessCheckProcessor.java 1 75.86%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/service/helper/ReferenceRegisterHelper.java 2 76.19%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ServiceFactoryBean.java 2 69.44%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java 3 0.0%
test-sofa-boot-starter/src/main/java/com/alipay/sofa/test/runner/SofaJUnit4Runner.java 3 56.67%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java 4 52.38%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/configuration/HealthCheckConfiguration.java 4 40.0%
healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/AfterHealthCheckCallbackProcessor.java 4 60.87%
Totals Coverage Status
Change from base Build 358: 0.0%
Covered Lines: 1450
Relevant Lines: 2233

💛 - Coveralls

@guanchao-yang guanchao-yang self-requested a review July 28, 2018 13:21
@guanchao-yang guanchao-yang self-assigned this Jul 28, 2018
@guanchao-yang guanchao-yang added the bug Something isn't working label Jul 28, 2018
@guanchao-yang guanchao-yang added this to the 2.4.4 milestone Jul 28, 2018
@guanchao-yang guanchao-yang merged commit 158e53d into sofastack:2.4.x Jul 28, 2018
@QilongZhang
Copy link
Contributor

@guanchao-yang we can just add the sofa-version-maven-plugin in the root pom as follows:

<plugin>
    <groupId>com.alipay.sofa</groupId>
    <artifactId>sofa-version-maven-plugin</artifactId>
    <version>1.0.1</version>
    <configuration>
        <dotGitDirectory>${main.user.dir}/.git</dotGitDirectory>
        <defaultPropertiesFileEntries>
            <Doc-Url>http://www.sofastack.tech/sofa-boot/docs/Home</Doc-Url>
        </defaultPropertiesFileEntries>
    </configuration>
    <executions>
        <execution>
            <goals>
                <goal>gen</goal>
                <goal>write</goal>
            </goals>
        </execution>
    </executions>
</plugin>

please simplify it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants