Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support whether component can be duplicated registered #199

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Support whether component can be duplicated registered #199

merged 1 commit into from
Sep 6, 2018

Conversation

straybirdzls
Copy link
Member

fix #187

@straybirdzls straybirdzls added enhancement New feature or request document The document was modified and removed document The document was modified labels Aug 27, 2018
@straybirdzls straybirdzls added this to In progress in v2.5.0 via automation Aug 27, 2018
@straybirdzls straybirdzls added this to the 2.5.0 milestone Aug 27, 2018
@coveralls
Copy link

coveralls commented Aug 27, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 442

  • 2 of 7 (28.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 71.568%
Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spi/component/AbstractComponent.java 0 1 0.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/component/impl/ComponentManagerImpl.java 2 6 33.33%
Totals Coverage Status
Change from base Build 428: 0.7%
Covered Lines: 1465
Relevant Lines: 2047
💛 - Coveralls

@QilongZhang QilongZhang self-requested a review August 31, 2018 00:57
@QilongZhang QilongZhang merged commit 3e2ac48 into sofastack:master Sep 6, 2018
v2.5.0 automation moved this from In progress to Done Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongZhang QilongZhang QilongZhang approved these changes

@caojie09 caojie09 Awaiting requested review from caojie09

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
v2.5.0
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Support whether component can be duplicated registered
3 participants
@straybirdzls @coveralls @QilongZhang