Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suport full annotation style #329

Merged
merged 9 commits into from
Jan 3, 2019
Merged

Suport full annotation style #329

merged 9 commits into from
Jan 3, 2019

Conversation

QilongZhang
Copy link
Contributor

@QilongZhang QilongZhang commented Jan 2, 2019 •
edited
Loading

cherry-pick and some compatible change in spring boot 1.x
#328
#320
#304
#306

@QilongZhang QilongZhang added the enhancement New feature or request label Jan 2, 2019
@QilongZhang QilongZhang added this to the 2.6.0 milestone Jan 2, 2019
@coveralls
Copy link

coveralls commented Jan 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 690

  • 84 of 95 (88.42%) changed or added relevant lines in 8 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.9%) to 72.893%
Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/bean/SofaBeanNameGenerator.java 11 14 78.57%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java 11 19 57.89%
Files with Coverage Reduction New Missed Lines %
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/listener/SofaBootstrapRunListener.java 1 83.64%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spi/component/DefaultImplementation.java 3 29.41%
infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/log/space/SofaBootLogSpaceIsolationInit.java 11 0.0%
Totals Coverage Status
Change from base Build 664: 0.9%
Covered Lines: 1721
Relevant Lines: 2361
💛 - Coveralls

@glmapper glmapper merged commit 3165b16 into sofastack:2.x Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straybirdzls straybirdzls straybirdzls approved these changes

@glmapper glmapper glmapper approved these changes

@caojie09 caojie09 caojie09 approved these changes

@ujjboy ujjboy Awaiting requested review from ujjboy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@QilongZhang @coveralls @straybirdzls @glmapper @caojie09