This repository has been archived by the owner on May 30, 2022. It is now read-only.
consul registry support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #113 |
Codecov Report
@@ Coverage Diff @@
## 5.x #126 +/- ##
============================================
+ Coverage 54.85% 55.08% +0.22%
- Complexity 393 399 +6
============================================
Files 53 54 +1
Lines 1741 1781 +40
Branches 310 316 +6
============================================
+ Hits 955 981 +26
- Misses 606 615 +9
- Partials 180 185 +5
Continue to review full report at Codecov.
|
JervyShi
reviewed
Dec 3, 2018
| Map<String, String> map = parseParam(address); | ||
| return new RegistryConfig() | ||
| .setAddress(consulAddress) | ||
| .setProtocol(SofaBootRpcConfigConstants.REGISTRY_PROTOCOL_ZOOKEEPER) |
There was a problem hiding this comment.
Wrong constants REGISTRY_PROTOCOL_ZOOKEEPER
leizhiyuan
added a commit
that referenced
this pull request
Mar 8, 2019
* Consul registry support (#126) * consul registry support * fix cr * Support nacos converter (#130) * Upgrade version * Support nacos address converter * Hystrix switcher (#137) * support enableHystrix * support enableHystrix * hystrix enable * Add nacos client dependency support. (#148) * Zk auth support. (#156) * Server config for rest cors. (#155) * server config for rest cors * add test case for cors
leizhiyuan
added a commit
that referenced
this pull request
May 21, 2019
* consul registry support * fix cr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
add configure option for consul
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.