Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Add swagger support for SOFARPC restful #131

Merged
merged 9 commits into from
Feb 11, 2019

Conversation

khotyn
Copy link
Member

@khotyn khotyn commented Dec 9, 2018

Add swagger support for SOFARPC restful services.

@khotyn
Copy link
Member Author

khotyn commented Dec 9, 2018

Users can add swagger dependencies and add com.alipay.sofa.rpc.rest-swagger=true in applications.properties to enable swagger openapi support, the swagger openapi will be available at http://localhost:8341/swagger/openapi

@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #131 into master will increase coverage by 0.96%.
The diff coverage is 67.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #131      +/-   ##
===========================================
+ Coverage     57.33%   58.3%   +0.96%     
- Complexity      417     436      +19     
===========================================
  Files            54      56       +2     
  Lines          1751    1806      +55     
  Branches        313     318       +5     
===========================================
+ Hits           1004    1053      +49     
- Misses          541     548       +7     
+ Partials        206     205       -1
Impacted Files Coverage Δ Complexity Δ
...oot/swagger/SwaggerServiceApplicationListener.java 100% <100%> (ø) 3 <3> (?)
...ay/sofa/rpc/boot/SofaBootRpcAutoConfiguration.java 95.45% <100%> (+0.21%) 15 <1> (+1) ⬆️
...ipay/sofa/rpc/boot/swagger/SwaggerServiceImpl.java 56.41% <56.41%> (ø) 9 <9> (?)
...ay/sofa/rpc/boot/config/SofaBootRpcProperties.java 56.65% <66.66%> (+0.15%) 89 <1> (+1) ⬆️
...sofa/rpc/boot/container/ServerConfigContainer.java 83.33% <0%> (+0.5%) 45% <0%> (+1%) ⬆️
...ipay/sofa/rpc/boot/runtime/binding/RpcBinding.java 39.34% <0%> (+1.63%) 15% <0%> (+1%) ⬆️
...fa/rpc/boot/runtime/adapter/RpcBindingAdapter.java 42.37% <0%> (+15.25%) 6% <0%> (+2%) ⬆️
.../sofa/rpc/boot/runtime/param/RestBindingParam.java 100% <0%> (+50%) 2% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0449b...bc6dd98. Read the comment docs.

import com.alipay.sofa.rpc.boot.config.SofaBootRpcConfigConstants;
import com.alipay.sofa.rpc.boot.config.SofaBootRpcProperties;
import com.alipay.sofa.rpc.boot.config.ZookeeperConfigurator;
import com.alipay.sofa.rpc.boot.config.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should avoid using import * here. You can change idea settings from Editor - Code Style - Java - Imports - import with '*' to 999 etc and then format code again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as you suggested.

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leizhiyuan
Copy link
Contributor

we will not change version to stable version number until we prepare to release, so we can release some snapshot for test.

@khotyn
Copy link
Member Author

khotyn commented Dec 11, 2018

@leizhiyuan You mean sofaboot-dependencies's version?

@leizhiyuan
Copy link
Contributor

ok, I see,sofaboot-dependencies 310 has released four days ago.

@JervyShi JervyShi changed the base branch from master to 5.x December 18, 2018 04:19
@JervyShi JervyShi changed the base branch from 5.x to master December 18, 2018 04:19
@leizhiyuan leizhiyuan added this to the 6.0.1 milestone Dec 18, 2018
@leizhiyuan leizhiyuan added the enhancement New feature or request label Feb 11, 2019
@leizhiyuan
Copy link
Contributor

after ci,I will merge this pr to master

@leizhiyuan leizhiyuan merged commit fa7cea7 into master Feb 11, 2019
@JervyShi JervyShi deleted the add_restful_swagger_support branch February 11, 2019 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants