Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Support additional custom parameters of RpcBindingParam. #73

Merged
merged 1 commit into from Jul 13, 2018
Merged

Support additional custom parameters of RpcBindingParam. #73

merged 1 commit into from Jul 13, 2018

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

allow the user to add custom parameters to URL

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan requested review from JervyShi and caojie09 and removed request for caojie09 July 13, 2018 04:09
@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #73 into master will decrease coverage by 0.13%.
The diff coverage is 11.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #73      +/-   ##
===========================================
- Coverage     55.93%   55.8%   -0.14%     
- Complexity      372     373       +1     
===========================================
  Files            51      51              
  Lines          1609    1620      +11     
  Branches        270     274       +4     
===========================================
+ Hits            900     904       +4     
- Misses          551     555       +4     
- Partials        158     161       +3
Impacted Files Coverage Δ Complexity Δ
...t/runtime/adapter/helper/ConsumerConfigHelper.java 56.38% <50%> (-0.14%) 11 <0> (ø)
...t/runtime/adapter/helper/ProviderConfigHelper.java 53.96% <50%> (-0.14%) 5 <0> (ø)
...y/sofa/rpc/boot/runtime/param/RpcBindingParam.java 36.84% <6.66%> (-0.46%) 39 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f34686...47ba917. Read the comment docs.

@ujjboy ujjboy changed the title feature: convert paramter to consumer Support additional custom parameters of RpcBindingParam. Jul 13, 2018
@ujjboy ujjboy added the enhancement New feature or request label Jul 13, 2018
@ujjboy ujjboy added this to To do in v5.4.x via automation Jul 13, 2018
@ujjboy ujjboy added this to the 5.4.3 milestone Jul 13, 2018
@ujjboy ujjboy merged commit 21ee57a into sofastack:master Jul 13, 2018
v5.4.x automation moved this from To do to Done Jul 13, 2018
@leizhiyuan leizhiyuan deleted the support_custom_registry_parameter branch August 9, 2018 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
v5.4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants