Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when callback timeout, throw timeout exp as sync #359

Merged
merged 3 commits into from
Nov 9, 2018
Merged

when callback timeout, throw timeout exp as sync #359

merged 3 commits into from
Nov 9, 2018

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

fix #314

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #359 into 5.4 will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.4     #359      +/-   ##
============================================
- Coverage     71.48%   71.48%   -0.01%     
  Complexity      970      970              
============================================
  Files           346      346              
  Lines         14375    14378       +3     
  Branches       2307     2308       +1     
============================================
+ Hits          10276    10278       +2     
- Misses         2896     2899       +3     
+ Partials       1203     1201       -2
Impacted Files Coverage Δ Complexity Δ
...pay/sofa/rpc/message/bolt/BoltInvokerCallback.java 79.31% <40%> (-4.33%) 7 <0> (ø)
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 39.74% <0%> (-2.57%) 0% <0%> (ø)
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 88.7% <0%> (+1.61%) 0% <0%> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 76.92% <0%> (+4.61%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb90baf...c030b45. Read the comment docs.

@leizhiyuan leizhiyuan added this to the 5.4.8 milestone Nov 8, 2018
@QilongZhang QilongZhang merged commit 8f8aff0 into sofastack:5.4 Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants