Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as server, we make server not be daemon #370

Merged
merged 7 commits into from Nov 29, 2018
Merged

as server, we make server not be daemon #370

merged 7 commits into from Nov 29, 2018

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Nov 19, 2018

Motivation:

change

"server.daemon": true,

to

 "server.daemon": false,

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #364

If there is no issue then describe the changes introduced by this PR.

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (5.4@f26156e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             5.4     #370   +/-   ##
======================================
  Coverage       ?   71.63%           
  Complexity     ?      977           
======================================
  Files          ?      348           
  Lines          ?    14462           
  Branches       ?     2317           
======================================
  Hits           ?    10360           
  Misses         ?     2887           
  Partials       ?     1215

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26156e...2c79e45. Read the comment docs.

@leizhiyuan leizhiyuan added this to the 5.4.8 milestone Nov 24, 2018
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leizhiyuan leizhiyuan merged commit e32bd7c into sofastack:5.4 Nov 29, 2018
@leizhiyuan leizhiyuan deleted the make_rest_server_not_daemon branch November 29, 2018 06:39
@NeGnail
Copy link
Contributor

NeGnail commented Nov 29, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants