New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix generic invoke retries bug #608
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.5 #608 +/- ##
============================================
+ Coverage 70.93% 71.14% +0.21%
- Complexity 1141 1147 +6
============================================
Files 377 377
Lines 15160 15784 +624
Branches 2472 2556 +84
============================================
+ Hits 10754 11230 +476
- Misses 3086 3215 +129
- Partials 1320 1339 +19
Continue to review full report at Codecov.
|
|
||
final String revised = (String) request.getRequestProp(REVISE_KEY); | ||
//if has revised, invoke directly | ||
if (StringUtils.isNotBlank(revised) && REVISE_VALUE.equals(revised)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if
can be simplify to REVISE_VALUE.equals(revised)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
* fix generic invoke retries bug * fix for cr
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #600
If there is no issue then describe the changes introduced by this PR.