Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generic invoke retries bug #608

Merged
merged 2 commits into from May 6, 2019
Merged

fix generic invoke retries bug #608

merged 2 commits into from May 6, 2019

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #600

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan added this to the 5.5.3 milestone May 5, 2019
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #608 into 5.5 will increase coverage by 0.21%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.5     #608      +/-   ##
============================================
+ Coverage     70.93%   71.14%   +0.21%     
- Complexity     1141     1147       +6     
============================================
  Files           377      377              
  Lines         15160    15784     +624     
  Branches       2472     2556      +84     
============================================
+ Hits          10754    11230     +476     
- Misses         3086     3215     +129     
- Partials       1320     1339      +19
Impacted Files Coverage Δ Complexity Δ
.../alipay/sofa/rpc/filter/ConsumerGenericFilter.java 83.33% <75%> (-0.39%) 15 <3> (+1)
...java/com/alipay/sofa/rpc/context/AsyncRuntime.java 53.84% <0%> (-9.8%) 0% <0%> (ø)
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 54.12% <0%> (-7.33%) 0% <0%> (ø)
...alipay/sofa/rpc/api/future/SofaResponseFuture.java 55.17% <0%> (-6.37%) 5% <0%> (ø)
...pay/sofa/rpc/transport/http/SslContextBuilder.java 18.75% <0%> (-6.25%) 2% <0%> (ø)
...ay/sofa/rpc/protocol/telnet/HelpTelnetHandler.java 82.35% <0%> (-5.15%) 0% <0%> (ø)
...fa/rpc/registry/consul/internal/ConsulManager.java 51% <0%> (-4.56%) 13% <0%> (+2%)
...va/com/alipay/sofa/rpc/client/FailoverCluster.java 74.28% <0%> (-4.29%) 0% <0%> (ø)
...ansport/bolt/ReuseBoltClientConnectionManager.java 68.11% <0%> (-3.76%) 23% <0%> (ø)
...pc/proxy/bytebuddy/BytebuddyInvocationHandler.java 78.94% <0%> (-3.41%) 0% <0%> (ø)
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44481d2...ad0b5e9. Read the comment docs.


final String revised = (String) request.getRequestProp(REVISE_KEY);
//if has revised, invoke directly
if (StringUtils.isNotBlank(revised) && REVISE_VALUE.equals(revised)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if can be simplify to REVISE_VALUE.equals(revised)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@leizhiyuan leizhiyuan merged commit 702a143 into sofastack:5.5 May 6, 2019
@leizhiyuan leizhiyuan deleted the fix_generic_invoke_retry branch May 6, 2019 07:00
leizhiyuan added a commit that referenced this pull request May 13, 2019
* fix generic invoke retries bug

* fix for cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants