Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failover cluster invoke bug #650

Merged
merged 3 commits into from Jun 17, 2019
Merged

fix failover cluster invoke bug #650

merged 3 commits into from Jun 17, 2019

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Jun 5, 2019

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #648

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan requested a review from ujjboy June 5, 2019 02:54
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan added this to the 5.5.6 milestone Jun 12, 2019
@QilongZhang QilongZhang removed this from the 5.5.6 milestone Jun 13, 2019
@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #650 into 5.5 will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.5     #650      +/-   ##
============================================
- Coverage     70.92%   70.89%   -0.03%     
  Complexity     1150     1150              
============================================
  Files           382      382              
  Lines         15887    15888       +1     
  Branches       2567     2567              
============================================
- Hits          11268    11264       -4     
- Misses         3275     3281       +6     
+ Partials       1344     1343       -1
Impacted Files Coverage Δ Complexity Δ
...va/com/alipay/sofa/rpc/client/FailoverCluster.java 72.22% <0%> (-2.07%) 0 <0> (ø)
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.63% <0%> (-31.58%) 3% <0%> (-1%)
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 67.2% <0%> (-5.6%) 23% <0%> (-3%)
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 90.32% <0%> (-1.62%) 0% <0%> (ø)
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 88.27% <0%> (-0.93%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/server/rest/RestServer.java 73.27% <0%> (-0.87%) 0% <0%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 90.24% <0%> (+1.21%) 0% <0%> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...pay/sofa/rpc/message/bolt/BoltInvokerCallback.java 81.03% <0%> (+1.72%) 8% <0%> (+1%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 82.14% <0%> (+1.78%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc42b9e...0c2d52c. Read the comment docs.

@leizhiyuan leizhiyuan modified the milestones: 5.5.6, 5.5.7 Jun 17, 2019
@leizhiyuan leizhiyuan merged commit 6487ce8 into sofastack:5.5 Jun 17, 2019
@leizhiyuan leizhiyuan deleted the fix_failover_cluster_bug branch June 17, 2019 13:39
zonghaishang added a commit that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants