Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rest leak bug #731

Merged
merged 3 commits into from
Aug 21, 2019
Merged

fix rest leak bug #731

merged 3 commits into from
Aug 21, 2019

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Aug 12, 2019

Motivation:

thanks https://github.com/sofastack/sofa-rpc/pull/593/files

拷贝了netty的inputstream来取消对netty的依赖

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/L labels Aug 12, 2019
@leizhiyuan leizhiyuan requested a review from ujjboy August 12, 2019 10:24
@leizhiyuan leizhiyuan added this to the 5.5.7 milestone Aug 12, 2019
@leizhiyuan
Copy link
Contributor Author

see #592

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #731 into 5.5 will decrease coverage by 0.16%.
The diff coverage is 36.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.5     #731      +/-   ##
============================================
- Coverage     70.72%   70.55%   -0.17%     
- Complexity     1145     1148       +3     
============================================
  Files           382      386       +4     
  Lines         15903    16045     +142     
  Branches       2564     2587      +23     
============================================
+ Hits          11247    11321      +74     
- Misses         3316     3380      +64     
- Partials       1340     1344       +4
Impacted Files Coverage Δ Complexity Δ
...pay/sofa/rpc/server/rest/SofaNettyJaxrsServer.java 56.31% <100%> (ø) 0 <0> (ø) ⬇️
.../sofa/rpc/server/rest/NettyByteBufInputStream.java 23.07% <23.07%> (ø) 0 <0> (?)
...y/sofa/rpc/server/rest/SofaRestRequestHandler.java 51.61% <66.66%> (+0.76%) 0 <0> (ø) ⬇️
...pc/server/rest/SofaRestEasyHttpRequestDecoder.java 77.77% <77.77%> (ø) 0 <0> (?)
...pay/sofa/rpc/client/aft/InvocationStatFactory.java 82.92% <0%> (-2.08%) 15% <0%> (ø)
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 90.32% <0%> (-1.62%) 0% <0%> (ø)
...in/java/com/alipay/sofa/rpc/common/RpcConfigs.java 77.16% <0%> (-0.62%) 0% <0%> (ø)
...ava/com/alipay/sofa/rpc/test/HelloServiceImpl.java 92.3% <0%> (ø) 0% <0%> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0efc7...472987b. Read the comment docs.

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy requested a review from a team August 20, 2019 12:56
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan merged commit 2abbaff into sofastack:5.5 Aug 21, 2019
@leizhiyuan leizhiyuan deleted the fix_rest_leak_bug branch August 21, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants