-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rest leak bug #731
fix rest leak bug #731
Conversation
see #592 |
Codecov Report
@@ Coverage Diff @@
## 5.5 #731 +/- ##
============================================
- Coverage 70.72% 70.55% -0.17%
- Complexity 1145 1148 +3
============================================
Files 382 386 +4
Lines 15903 16045 +142
Branches 2564 2587 +23
============================================
+ Hits 11247 11321 +74
- Misses 3316 3380 +64
- Partials 1340 1344 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation:
thanks https://github.com/sofastack/sofa-rpc/pull/593/files
拷贝了netty的inputstream来取消对netty的依赖
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.