-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generic invoke method name #768
Fix generic invoke method name #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Codecov Report
@@ Coverage Diff @@
## 5.5 #768 +/- ##
=====================================
Coverage ? 70.7%
Complexity ? 1144
=====================================
Files ? 386
Lines ? 16065
Branches ? 2590
=====================================
Hits ? 11359
Misses ? 3347
Partials ? 1359
Continue to review full report at Codecov.
|
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
{"timestamp":"2019-09-19 08:16:05.659","tracerId":"1e27a7d51568852165656101897688","spanId":"0","span.kind":"client","local.app":"generic-client","protocol":"bolt","service":"com.alipay.sofa.rpc.invoke.generic.TestGenericService:1.0","method":"echoObj","current.thread.name":"main","invoke.type":"sync","router.record":"DIRECT","remote.app":"generic-server","remote.ip":"127.0.0.1:22222","local.client.ip":"127.0.0.1","result.code":"00","req.serialize.time":"0","resp.deserialize.time":"3","resp.size":"225","req.size":"1384","client.conn.time":"0","client.elapse.time":"3","local.client.port":"22222","baggage":""}
Result:
Fixes ##767
If there is no issue then describe the changes introduced by this PR.