Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic invoke method name #768

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix generic invoke method name #768

merged 2 commits into from
Sep 23, 2019

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

{"timestamp":"2019-09-19 08:16:05.659","tracerId":"1e27a7d51568852165656101897688","spanId":"0","span.kind":"client","local.app":"generic-client","protocol":"bolt","service":"com.alipay.sofa.rpc.invoke.generic.TestGenericService:1.0","method":"echoObj","current.thread.name":"main","invoke.type":"sync","router.record":"DIRECT","remote.app":"generic-server","remote.ip":"127.0.0.1:22222","local.client.ip":"127.0.0.1","result.code":"00","req.serialize.time":"0","resp.deserialize.time":"3","resp.size":"225","req.size":"1384","client.conn.time":"0","client.elapse.time":"3","local.client.port":"22222","baggage":""}

Result:

Fixes ##767

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/XXL labels Sep 19, 2019
@leizhiyuan leizhiyuan changed the base branch from master to 5.5 September 19, 2019 00:17
@leizhiyuan leizhiyuan added this to the 5.5.8 milestone Sep 19, 2019
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofastack-bot sofastack-bot bot added size/S and removed size/XXL labels Sep 23, 2019
@leizhiyuan
Copy link
Contributor Author

{"timestamp":"2019-09-23 10:48:38.688","tracerId":"0a0ffb091569206918683101257027","spanId":"0","span.kind":"client","local.app":"generic-client","protocol":"bolt","service":"com.alipay.sofa.rpc.invoke.generic.TestGenericService:1.0","method":"echoObj","current.thread.name":"main","invoke.type":"sync","router.record":"DIRECT","remote.app":"generic-server","remote.ip":"127.0.0.1:22222","local.client.ip":"127.0.0.1","result.code":"00","req.serialize.time":"1","resp.deserialize.time":"4","resp.size":"225","req.size":"1384","client.conn.time":"0","client.elapse.time":"5","local.client.port":"22222","baggage":""}

@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (5.5@7087c22). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@          Coverage Diff          @@
##             5.5    #768   +/-   ##
=====================================
  Coverage       ?   70.7%           
  Complexity     ?    1144           
=====================================
  Files          ?     386           
  Lines          ?   16065           
  Branches       ?    2590           
=====================================
  Hits           ?   11359           
  Misses         ?    3347           
  Partials       ?    1359
Impacted Files Coverage Δ Complexity Δ
.../alipay/sofa/rpc/filter/ConsumerGenericFilter.java 82.69% <75%> (ø) 15 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7087c22...13f7944. Read the comment docs.

@sofastack-bot sofastack-bot bot added size/XS and removed size/S labels Sep 23, 2019
@leizhiyuan leizhiyuan merged commit 987a85d into sofastack:5.5 Sep 23, 2019
@leizhiyuan leizhiyuan deleted the fix_generic_invoke_method_name branch September 23, 2019 04:02
leizhiyuan added a commit that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants