Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFATracer remote report data to Zipkin version 2.1.X version problem #57

Closed
guanchao-yang opened this issue Aug 25, 2018 · 1 comment · Fixed by #60
Closed

SOFATracer remote report data to Zipkin version 2.1.X version problem #57

guanchao-yang opened this issue Aug 25, 2018 · 1 comment · Fixed by #60
Assignees
Labels
bug Something isn't working enhancement New feature or request
Projects
Milestone

Comments

@guanchao-yang
Copy link
Member

guanchao-yang commented Aug 25, 2018

Describe the bug

  • 1.TraceId we print to disk and report to Zipkin length are not equal.Such as print disk is 0a0fe87a153519650379710017813 ,but in Zipkin

image

  • 2.SpanId and parentSpanId error. The parentSpanId in Zipkin version 2.1.X report is blank ,

image

If no parentSpanId the SOFATracer Link path will hava no layer.

Expected behavior

TraceId should be same and Zipkin view has the SOFATracer link path layer.

Actual behavior

TraceId not same and parentSpanId error.

Steps to reproduce

Can use such example

@guanchao-yang guanchao-yang added bug Something isn't working enhancement New feature or request labels Aug 25, 2018
@guanchao-yang guanchao-yang added this to the 2.2.0 milestone Aug 25, 2018
@guanchao-yang guanchao-yang added this to To do in v2.2.0 via automation Aug 25, 2018
@glmapper
Copy link
Contributor

glmapper commented Aug 29, 2018

About the first question:The zipkin's spanId is 16 or 32 bits. If it is not satisfied, it will be padleft.as follows:

if (length == 32 || length == 16) {
    return traceId;
} else if (length < 16) {
    return padLeft(traceId, 16);
} else {
    return padLeft(traceId, 32);
}

question 2:The zipkin parentId is empty. Because in v2,v2 span model Unsets the {@link Span#parentId()} if the input is 0.So we don't need to convert hex to decimal, use FNV64HashCode to convert String to long will be OK.

And the last question,root span is not supposed to have parent AFAIK

v2.2.0 automation moved this from To do to Done Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
v2.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants