Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused code #36

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Delete unused code #36

merged 1 commit into from
Jul 24, 2018

Conversation

khotyn
Copy link
Member

@khotyn khotyn commented Jul 24, 2018

Some code in TraceIdGenerator is not unused, so delete those code.

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Some code in TraceIdGenerator is not used, so delete those code.
@khotyn khotyn changed the title Delete unsed code Delete unused code Jul 24, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 47

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.5%) to 48.397%

Files with Coverage Reduction New Missed Lines %
tracer-core/src/main/java/com/alipay/common/tracer/core/generator/TraceIdGenerator.java 2 88.46%
Totals Coverage Status
Change from base Build 45: 1.5%
Covered Lines: 1555
Relevant Lines: 3213

💛 - Coveralls

@guanchao-yang guanchao-yang merged commit 67df0d9 into master Jul 24, 2018
@khotyn khotyn deleted the delete_unused_code branch July 25, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants