Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aynsc servlet #63

Merged
merged 13 commits into from
Aug 31, 2018
Merged

Fix aynsc servlet #63

merged 13 commits into from
Aug 31, 2018

Conversation

guanchao-yang
Copy link
Member

Motivation:

Fix aynsc servlet error like

llegalStateException: getOutputStream() has already been called for this response

Modification:

Change the usage of the HttpServletResponse and avoid double call the getOutputStream method

Result:

Fixes #62

@guanchao-yang guanchao-yang added bug Something isn't working enhancement New feature or request labels Aug 31, 2018
@guanchao-yang guanchao-yang mentioned this pull request Aug 31, 2018
Closed
@guanchao-yang guanchao-yang added this to the 2.1.4 milestone Aug 31, 2018
@coveralls
Copy link

coveralls commented Aug 31, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.301%
Totals Coverage Status
Change from base Build 124: 0.0%
Covered Lines: 1657
Relevant Lines: 3361
💛 - Coveralls

@glmapper glmapper merged commit b9ef652 into v2.1.X Aug 31, 2018
@guanchao-yang guanchao-yang deleted the fix_aynsc_servlet branch August 31, 2018 10:46
ujjboy pushed a commit that referenced this pull request Sep 11, 2018
@guanchao-yang @ujjboy
Fix aynsc servlet (#63)
8149b98 
(cherry picked from commit b9ef652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy Awaiting requested review from ujjboy

@glmapper glmapper Awaiting requested review from glmapper

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guanchao-yang @coveralls @glmapper