Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the phantomjs config to include --ssl-protocol=tlsv1 #29

Merged
merged 1 commit into from May 30, 2015

Conversation

lsuresh
Copy link

@lsuresh lsuresh commented May 28, 2015

When I was testing the holmium against the phantomJS [V1.9.7/1.9.8] , it's unable to find the elements in couple of sites including zopim because of SSL cert issue .

google.com , abc.go.com works fine but accounts.zopim.com, zopim.com,yahoo.com fails

existing code:

class PhantomConfig(DriverConfig):
"""
configuration for phantomjs
"""
def call(self, config, args):
if config.ignore_ssl:
args.setdefault("service_args", []).append(
"--ignore-ssl-errors=true")
return super(PhantomConfig, self).call(config, args)

changes requires for 1.9.7 and 1.9.8:

class PhantomConfig(DriverConfig):
"""
configuration for phantomjs
"""
def call(self, config, args):
if config.ignore_ssl:
args.setdefault("service_args", []).append(
"--ignore-ssl-errors=true --ssl-protocol=tlsv1 ")
return super(PhantomConfig, self).call(config, args)

When I install the PhantomJS 2.0.0 existing code works fine. Suggest if we need to change the holmium core to support 1.9.7 and 1.9.8.

Please note that phantomJS2.0.0 release is not available for the Linux platform. I have compiled developer release to test 2.0.0.

Reference for the issue:

ariya/phantomjs#10389
http://stackoverflow.com/questions/12021578/phantomjs-failing-to-open-https-site

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.09% when pulling 0c95f70 on lsuresh:phantom1.9.x_fix into ca8bacb on alisaifee:master.

alisaifee added a commit that referenced this pull request May 30, 2015
updated the phantomjs config to include --ssl-protocol=tlsv1
@alisaifee alisaifee merged commit baa90c2 into alisaifee:master May 30, 2015
@alisaifee
Copy link
Owner

Thanks. Fix will be available in 0.7.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants