updated the phantomjs config to include --ssl-protocol=tlsv1 #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing the holmium against the phantomJS [V1.9.7/1.9.8] , it's unable to find the elements in couple of sites including zopim because of SSL cert issue .
google.com , abc.go.com works fine but accounts.zopim.com, zopim.com,yahoo.com fails
existing code:
class PhantomConfig(DriverConfig):
"""
configuration for phantomjs
"""
def call(self, config, args):
if config.ignore_ssl:
args.setdefault("service_args", []).append(
"--ignore-ssl-errors=true")
return super(PhantomConfig, self).call(config, args)
changes requires for 1.9.7 and 1.9.8:
class PhantomConfig(DriverConfig):
"""
configuration for phantomjs
"""
def call(self, config, args):
if config.ignore_ssl:
args.setdefault("service_args", []).append(
"--ignore-ssl-errors=true --ssl-protocol=tlsv1 ")
return super(PhantomConfig, self).call(config, args)
When I install the PhantomJS 2.0.0 existing code works fine. Suggest if we need to change the holmium core to support 1.9.7 and 1.9.8.
Please note that phantomJS2.0.0 release is not available for the Linux platform. I have compiled developer release to test 2.0.0.
Reference for the issue:
ariya/phantomjs#10389
http://stackoverflow.com/questions/12021578/phantomjs-failing-to-open-https-site