Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? responseWithError: method of OHHTTPStubsResponse class #6

Closed
yamaya opened this issue Nov 8, 2012 · 1 comment
Closed

Bug? responseWithError: method of OHHTTPStubsResponse class #6

yamaya opened this issue Nov 8, 2012 · 1 comment

Comments

@yamaya
Copy link

yamaya commented Nov 8, 2012

+(OHHTTPStubsResponse*)responseWithError:(NSError*)error
{
    OHHTTPStubsResponse* response = [[self  alloc] initWithError:error];
#if ! __has_feature(objc_arc)
    [response release]; <------------ Why?
#endif
    return response;
}

You should use "autorelease" instead of "release"?

@AliSoftware
Copy link
Owner

Good catch! Yes indeed this should be autorelease, thanks.

AliSoftware added a commit that referenced this issue Nov 8, 2012
AliSoftware added a commit that referenced this issue Nov 3, 2015
byohay added a commit to byohay/OHHTTPStubs that referenced this issue Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants