Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Carthage #9

Closed
narirou opened this issue Feb 4, 2016 · 4 comments
Closed

Support Carthage #9

narirou opened this issue Feb 4, 2016 · 4 comments

Comments

@narirou
Copy link
Contributor

narirou commented Feb 4, 2016

This project now supports CocoaPods and Swift Version Manager.
Could you add Carthage installation support to this project?

Thanks.

@AliSoftware
Copy link
Owner

Yeah, sure!

But just to let you know, note that given this is gonna need settings up an Xcode project, configure a target for each platform the lib supports, and maintain it (Carthage requests quite some maintenance work from a lib author perspective compared to CP and SPM, and CocoaPods-Rome already supports the same behavior as Carthage without any additional work for the lib author so…), I may not gonna add this very soon (I'm quite busy lately). So I hope this is not urgent.

I might probably need to implement #7 first (to create the lib Xcode project so I can host the tests) before configuring everything for Carthage anyway.

BTW, feel free to make a PR to add this yourself if you need it urgently, That way I'd be able to merge it quicker & add Carthage support sooner 😉

@narirou
Copy link
Contributor Author

narirou commented Feb 29, 2016

Thanks!
I understood this issue's priority.
If possible, I will try carthage support as PR. :)

@AliSoftware
Copy link
Owner

This should have been fixed by #25 !

Will close this issue now (please reopen if this still doesn't work)

@narirou
Copy link
Contributor Author

narirou commented Nov 14, 2016

Thank you so match! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants