Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback! #1

Open
codepathreview opened this issue Sep 18, 2017 · 2 comments
Open

Project Feedback! #1

codepathreview opened this issue Sep 18, 2017 · 2 comments

Comments

@codepathreview
Copy link

👍 Good work getting all required and few optional stories done. A few notes after checking out the code:

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.
Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.

P.S. Good to see you properly added the README with features and GIF to your project as described in the submitting assignments guide!

@codepathreview
Copy link
Author

@alitsiya, sorry didnt realize the ViewHolder is a requirement for assignment, pls complete that and update status here
/cc @codepathreview

@alitsiya
Copy link
Owner

alitsiya commented Sep 18, 2017

@codepathreview Added ViewHolder, please revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants