User service #38
Merged
User service #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
moustaphastar
commented
Sep 28, 2021
moustaphastar
commented
- Implemented new endpoints and objects in order
- to get a paged list of users
- to get a single user
- delete a user
- Added access rule for delete and list endpoints
- Implemented user page, details modal and api request for admin panel.
Closed
Closed
|
Create user (#31 ) implementation is missing. |
moustaphastar
commented
Sep 28, 2021
|
|
||
|
|
||
| const columns = [ | ||
| "id", "Ad", "Email", "Telefon", "Lokasyon", "İşlemler" |
There was a problem hiding this comment.
What columns to show/hide?
| path: "/api/v1/file", | ||
| data: formData, | ||
| params: ["firebasePath"], | ||
| values: ["product-images"] |
There was a problem hiding this comment.
Value should be user-image
There was a problem hiding this comment.
Also, do we have the implementation to add a user image?
|
|
||
| @Override | ||
| public UserImageInsertResponse insertUserImage(UserImageInsertRequest request) { | ||
| return new UserImageInsertResponse(); |
There was a problem hiding this comment.
User image insertion is done through FileResource endpoints.
| public ResponseEntity<PageResponse<UserResponse>> pageList( | ||
| @RequestParam("page") int page, | ||
| @RequestParam("size") int size) { | ||
| Authentication auth = SecurityContextHolder.getContext().getAuthentication(); |
There was a problem hiding this comment.
Can we refactor to use hasRole or hasAuthority annotations?
aliturgutbozkurt
approved these changes
Oct 2, 2021
| @Mapping(target = "revisedAt", | ||
| dateFormat = "dd-MM-yyyy HH:mm:ss") | ||
| UserResponse entityToUserResponse(UserEntity entity); | ||
|
|
There was a problem hiding this comment.
We don't need target attribute for entity properties that has same name with response property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.