Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change factorisation notation so that it matches the paper #1

Closed
faroit opened this issue Mar 14, 2016 · 1 comment
Closed

Change factorisation notation so that it matches the paper #1

faroit opened this issue Mar 14, 2016 · 1 comment
Labels
enhancement

Comments

@faroit
Copy link
Owner

faroit commented Mar 14, 2016

https://github.com/aliutkus/commonfate/blob/master/commonfate/model.py#L121

is different to paper where we state:

notation

the output should therefore be changed to
(A, H, C)
@faroit
Copy link
Owner Author

faroit commented Mar 20, 2016

fixed in 2b4a27d

@faroit faroit closed this as completed Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faroit