Add user agent for log service client #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uncleGen
requested changes
Oct 8, 2019
...gservice/src/main/java/org/apache/spark/streaming/aliyun/logservice/constants/Constants.java
Outdated
Show resolved
Hide resolved
Comment on lines
5
to
9
| /** | ||
| * @author jiashuangkai | ||
| * @version 1.0 | ||
| * @since 2019-09-27 14:56 | ||
| */ |
| @@ -0,0 +1,41 @@ | |||
| package org.apache.spark.streaming.aliyun.logservice.utils; | |||
| import java.util.Properties; | ||
|
|
||
| public class VersionInfoUtils { | ||
| private static final String VERSION_INFO_FILE = "spark-versioninfo.properties"; |
There was a problem hiding this comment.
It is better to use "versioninfo.properties" instead of "spark-versioninfo.properties"
There was a problem hiding this comment.
other sdk have this file: versioninfo.properties
There was a problem hiding this comment.
or you can use "emr-logservice-versioninfo.properties" instead.
| * @since 2019-09-27 14:56 | ||
| */ | ||
| public interface Constants { | ||
| String LOG_CONNECTOR_USER_AGENT = VersionInfoUtils.getDefaultUserAgent(); |
There was a problem hiding this comment.
Is there any need to add this new class?
There was a problem hiding this comment.
Many classes use this constant
There was a problem hiding this comment.
you can use "VersionInfoUtils.getDefaultUserAgent()" directly
|
Sign the CLA please |
|
LGTM，thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.