Initial add TableStore streaming source #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uncleGen
requested changes
Oct 11, 2019
emr-tablestore/pom.xml
Outdated
| @@ -18,7 +18,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.spark</groupId> | |||
| <artifactId>spark-core_${scala.binary.version}</artifactId> | |||
| <scope>provided</scope> | |||
| <scope>provided</scope> | |||
emr-tablestore/.scalafmt.conf
Outdated
| @@ -0,0 +1,9 @@ | |||
| version=2.0.0-RC5 | |||
There was a problem hiding this comment.
This file can be deleted?
| @@ -0,0 +1,13 @@ | |||
| package org.apache.spark.sql.aliyun.tablestore | |||
There was a problem hiding this comment.
all files add license header
| jCols.obj.map { case (name, jvalue) => | ||
| (name, jvalue.values.asInstanceOf[Map[String, String]]) | ||
| jCols.obj.map { | ||
| case (name, jvalue) => |
There was a problem hiding this comment.
minor: previous code style is just ok
There was a problem hiding this comment.
checkout to the previous version
Comment on lines
27
to
29
| )(@transient val sqlContext: SQLContext) extends Sink with Logging { | ||
| )(@transient val sqlContext: SQLContext) | ||
| extends Sink | ||
| with Logging { |
There was a problem hiding this comment.
minor: keep the previous code style here and other places
Comment on lines
21
to
24
| import com.alicloud.openservices.tablestore.model.tunnel.internal.{ | ||
| CheckpointRequest, | ||
| GetCheckpointRequest | ||
| } |
There was a problem hiding this comment.
minor: keep in same line
okingniko
force-pushed
the
master-2.x
branch
2 times, most recently
from
cbddf67
to
f4d3636
Compare
|
LGTM，thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial add TableStore streaming source