resource/alicloud_common_bandwidth_package: Renames the name to bandwidth_package_name; Adds new field status; Upgrades its dependence sdk #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zql-tqy
suggested changes
Mar 26, 2021
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| Deprecated: "Field 'name' has been deprecated from provider version 1.120.0. New field 'bandwidth_package_name' instead.", |
| Default: PayByTraffic, | ||
| ValidateFunc: validation.StringInSlice([]string{"PayByBandwidth", "PayBy95", "PayByTraffic"}, false), | ||
| ValidateFunc: validation.StringInSlice([]string{"PayBy95", "PayByBandwidth", "PayByTraffic"}, false), | ||
| Default: "PayByBandwidth", |
| @@ -36,6 +36,10 @@ The following arguments are supported: | |||
| * `name_regex` - (Optional) A regex string to filter results by name. | |||
| * `output_file` - (Optional) File name where to save data source results (after running `terraform plan`). | |||
| * `resource_group_id` - (Optional, ForceNew, Available in 1.58.0+) The Id of resource group which the common bandwidth package belongs. | |||
| * `bandwidth_package_name` - (Optional, ForceNew, Available in 1.120.0+) The name of bandwidth package. | |||
| * `internet_charge_type` - (Optional, ForceNew) The billing method of the common bandwidth package. Valid values are "PayByBandwidth" and "PayBy95" and "PayByTraffic". "PayBy95" is pay by classic 95th percentile pricing. International Account doesn't supports "PayByBandwidth" and "PayBy95". Default to "PayByTraffic". | ||
| * `ratio` - (Optional, ForceNew Available in 1.55.3+) Ratio of the common bandwidth package. It is valid when `internet_charge_type` is `PayBy95`. Default to 100. Valid values: [10-100]. | ||
| * `name` - (Optional) The name of the common bandwidth package. | ||
| * `internet_charge_type` - (Optional, ForceNew) The billing method of the common bandwidth package. Valid values are `PayByBandwidth` and `PayBy95` and `PayByTraffic`. `PayBy95` is pay by classic 95th percentile pricing. International Account doesn't supports `PayByBandwidth` and `PayBy95`. Default to `PayByTraffic`. |
|
|
||
| if d.HasChange("name") { | ||
| request.Name = d.Get("name").(string) | ||
| if !d.IsNewResource() && d.HasChange("bandwidth") { |
There was a problem hiding this comment.
所有变更属性都添加了 d.IsNewResource() 应该在 create 之后走 read 方法
liuri1205
force-pushed
the
pkg
branch
4 times, most recently
from
16d04fe
to
8baf44f
Compare
xiaozhu36
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.