resource/alicloud_ecs_snapshot: Deprecates the name and use snapshot_name instead; Adds more attributes; Upgrades the its dependence sdk #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuri1205
suggested changes
Apr 1, 2021
| ValidateFunc: validation.StringInSlice([]string{"auto", "user", "all"}, false), | ||
| Default: "all", | ||
| }, | ||
| "type": { |
| return WrapErrorf(err, IdMsg, d.Id()) | ||
| } | ||
|
|
||
| return resourceAlicloudEcsSnapshotUpdate(d, meta) |
There was a problem hiding this comment.
没有需要在update中设置的参数, 应该走read
| if err != nil { | ||
| return WrapErrorf(err, DataDefaultErrorMsg, "alicloud_ecs_snapshot", action, AlibabaCloudSdkGoERROR) | ||
| } | ||
| addDebug(action, response, request) |
| runtime.SetAutoretry(true) | ||
| response, err = conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2014-05-26"), StringPointer("AK"), nil, request, &runtime) | ||
| if err != nil { | ||
| return WrapErrorf(err, DataDefaultErrorMsg, "alicloud_ecs_snapshot", action, AlibabaCloudSdkGoERROR) |
There was a problem hiding this comment.
如果有错误打印 log 就行, 不需要 return err, 需要查询其他符合要求的的继续删除
There was a problem hiding this comment.
查询接口报错！错误需要抛出来，没办法继续往下走
| Delete: schema.DefaultTimeout(2 * time.Minute), | ||
| }, | ||
| Schema: map[string]*schema.Schema{ | ||
| "category": { |
| Required: true, | ||
| ForceNew: true, | ||
| }, | ||
| "name": { |
| runtime.SetAutoretry(true) | ||
| response, err = conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2014-05-26"), StringPointer("AK"), nil, request, &runtime) | ||
| if err != nil { | ||
| if IsExpectedErrors(err, []string{"InvalidFilterKey.NotFound", "InvalidFilterValue", "InvalidSnapshotIds.Malformed,InvalidStatus.NotFound,InvalidSnapshotType.NotFound", "InvalidSnapshotLinkId.NotFound", "InvalidSnapshotType.NotFound", "InvalidSourceDiskType", "InvalidStatus.NotFound", "InvalidUsage"}) { |
|
|
||
| This data source provides the Ecs Snapshots of the current Alibaba Cloud user. | ||
|
|
||
| -> **NOTE:** Available in v1.121.0+. |
| Optional: true, | ||
| Default: false, | ||
| }, | ||
| "instant_access": { |
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| }, | ||
| "instant_access_retention_days": { |
There was a problem hiding this comment.
instant_access_retention_days 范围值
liuri1205
suggested changes
Apr 2, 2021
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `category` - (Optional, ForceNew) The category of the snapshot. |
liuri1205
suggested changes
Apr 2, 2021
| @@ -9,6 +9,8 @@ description: |- | |||
|
|
|||
| # alicloud\_snapshots | |||
|
|
|||
| -> **DEPRECATED:** This datasource has been renamed to [alicloud_ecs_snapshots](https://www.terraform.io/docs/providers/alicloud/d/ecs_snapshots.html) from version 1.121.0. | |||
|
|
|||
There was a problem hiding this comment.
DataSource 和 resource 文档弃用版本 1.120.0
xiaozhu36
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.