Add new resource alicloud_gpdb_elastic_instance and no longer supports to create new alicloud_gpdb_instance resource #3727

PrinceHenson · 2021-07-14T11:46:42Z

No description provided.

liuri1205 · 2021-07-15T06:17:49Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+				Type:         schema.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.StringInSlice([]string{"Postpaid", "Prepaid"}, false),


payment_type 属性参考 alicloud_tsdb_instance 资源的方式处理下

liuri1205 · 2021-07-15T06:27:13Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+	d.Set("seg_node_num", instance["SegNodeNum"])
+	d.Set("storage_size", instance["StorageSize"])
+	d.Set("payment_type", instance["PayType"])
+	d.Set("instance_spec", convertDBInstanceClassToInstanceSpec(instance["DBInstanceClass"].(string)))


instance_spec 属性查询接口要支持返回, 不能通过 DBInstanceClass 去特殊处理获取

instance_spec 属性查询接口要支持返回, 不能通过 DBInstanceClass 去特殊处理获取

先这么搞，下周api修改发布之后再把特殊处理去掉。

liuri1205 · 2021-07-15T06:32:04Z

website/docs/r/gpdb_instance.html.markdown

@@ -19,6 +19,9 @@ You can see detail product introduction [here](https://www.alibabacloud.com/help

 -> **NOTE:**  Create instance or change instance would cost 10~15 minutes. Please make full preparation.

+-> **NOTE:**  This resource is used to manage a Reserved Storage Mode instance, and creating new reserved storage mode instance is no longer supported. 


标明从哪个版本开始不再支持

liuri1205 · 2021-07-15T06:32:41Z

website/docs/r/gpdb_elastic_instance.html.markdown

+
+The following arguments are supported:
+
+* `engine` (Required) Database engine: `gpdb`.


ForceNew 的属性也需要标识

liuri1205 · 2021-07-15T06:34:14Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+			"DBInstanceDescription": d.Get("description"),
+			"SourceIp":              client.SourceIp,
+		}
+		response, err := conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2016-05-03"), StringPointer("AK"), nil, request, &util.RuntimeOptions{})


使用 common 调用的接口, 对 err 都需要用 NeedRetry 函数判断进行重试

liuri1205 · 2021-07-15T08:31:05Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+	runtime.SetAutoretry(true)
+	request["ClientToken"] = buildClientToken("CreateECSDBInstance")
+	response, err = conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2016-05-03"), StringPointer("AK"), nil, request, &runtime)
+	if err != nil {


NeedRetry 重试

liuri1205 · 2021-07-15T08:32:13Z

alicloud/service_alicloud_gpdb.go

+	var response map[string]interface{}
+	runtime := util.RuntimeOptions{}
+	runtime.SetAutoretry(true)
+	response, err = conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2016-05-03"), StringPointer("AK"), nil, request, &runtime)


NeedRetry 重试

liuri1205 · 2021-07-15T08:33:27Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+
+import (
+	"fmt"
+	util "github.com/alibabacloud-go/tea-utils/service"


运行 make fmt 格式化下代码

liuri1205 · 2021-07-15T10:38:43Z

alicloud/resource_alicloud_gpdb_elastic_instance_test.go

+				}),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheck(map[string]string{
+						"description": fmt.Sprintf("tf-testAccGpdbInstance_6.0"),


查询接口返回的属性都需要 Check 一下

xiaozhu36 · 2021-07-16T02:12:44Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+			"seg_node_num": {
+				Type:     schema.TypeInt,
+				Required: true,
+				ForceNew: true,


Does the seg_node_num has validate values or some limitations?

xiaozhu36 · 2021-07-16T02:15:20Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+				ForceNew:     true,
+				ValidateFunc: validation.StringInSlice([]string{"PayAsYouGo", "Subscription"}, false),
+			},
+			"period": {


Please use the specific resource attribute payment_duration_unit instead period

xiaozhu36 · 2021-07-16T02:19:48Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+				Type:         schema.TypeString,
+				Optional:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.StringInSlice([]string{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12"}, false),


Please use the specific resource attribute payment_duration instead used_time

xiaozhu36 · 2021-07-16T02:20:20Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+			"storage_size": {
+				Type:     schema.TypeInt,
+				Required: true,
+				ForceNew: true,


Does the storage_size has validate values or some limitations?

xiaozhu36 · 2021-07-16T02:21:54Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+				Computed: true,
+			},
+			"security_ip_list": {
+				Type:     schema.TypeSet,


I think the security_ip_list type should be schema.TypeList.

xiaozhu36 · 2021-07-16T02:23:33Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+	if err != nil {
+		return WrapError(err)
+	}
+	if d.HasChange("description") {


The description has been set in the Create API and there should check the d.IsNewResource()

xiaozhu36 · 2021-07-16T02:24:17Z

alicloud/resource_alicloud_gpdb_elastic_instance.go

+	if d.IsNewResource() {
+		d.Partial(false)
+		return resourceAlicloudGpdbElasticInstanceRead(d, meta)
+	}


The block 272-275 is needless and it should be removed.

xiaozhu36 · 2021-07-16T02:26:52Z

alicloud/resource_alicloud_gpdb_elastic_instance_test.go

+						"security_ip_list.#":          "1",
+						"security_ip_list.4095458986": "10.168.1.12",
+					}),
+				),


There missing the updating all attributes testcase.

xiaozhu36 · 2021-07-16T02:28:23Z

alicloud/resource_alicloud_gpdb_instance.go

-		return WrapErrorf(err, IdMsg, d.Id())
-	}
-	return resourceAlicloudGpdbInstanceUpdate(d, meta)
+	return Error("Sorry, creating new reserved storage mode instance is no longer supported since v1.127.0, you can use alicloud_gpdb_elastic_instance to create a flexible storage mode instance instead.")


If the OpenAPI does not offline, there can not offline this resource. You can add the statement in its docs by a NOTE

xiaozhu36 · 2021-07-16T02:29:05Z

alicloud/resource_alicloud_gpdb_instance_test.go

@@ -108,7 +108,7 @@ func testSweepGpdbInstances(region string) error {
 	return nil
 }

-func TestAccAlicloudGpdbInstance_classic(t *testing.T) {
+func _TestAccAlicloudGpdbInstance_classic(t *testing.T) {


If you want to skip the testcase, you can add a prefix Skip in the testcase name.

…s to create new alicloud_gpdb_instance resource

PrinceHenson force-pushed the gpdb_develop branch 3 times, most recently from 012ec9d to a03a449 Compare July 15, 2021 05:42

liuri1205 suggested changes Jul 15, 2021

View reviewed changes

PrinceHenson force-pushed the gpdb_develop branch from a03a449 to 8216b00 Compare July 15, 2021 08:07

liuri1205 suggested changes Jul 15, 2021

View reviewed changes

PrinceHenson force-pushed the gpdb_develop branch from 8216b00 to 4ea4001 Compare July 15, 2021 09:56

liuri1205 suggested changes Jul 15, 2021

View reviewed changes

PrinceHenson force-pushed the gpdb_develop branch from 4ea4001 to 7efb92a Compare July 15, 2021 11:44

xiaozhu36 requested changes Jul 16, 2021

View reviewed changes

PrinceHenson force-pushed the gpdb_develop branch 3 times, most recently from 35aed56 to f81946c Compare July 16, 2021 09:13

Add new resource alicloud_gpdb_elastic_instance and no longer support…

65f4e54

…s to create new alicloud_gpdb_instance resource

PrinceHenson force-pushed the gpdb_develop branch from f81946c to 65f4e54 Compare July 16, 2021 12:13

xiaozhu36 merged commit fdf7b83 into aliyun:master Jul 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new resource alicloud_gpdb_elastic_instance and no longer supports to create new alicloud_gpdb_instance resource #3727

Add new resource alicloud_gpdb_elastic_instance and no longer supports to create new alicloud_gpdb_instance resource #3727

PrinceHenson commented Jul 14, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

PrinceHenson Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

liuri1205 Jul 15, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

xiaozhu36 Jul 16, 2021

		@@ -19,6 +19,9 @@ You can see detail product introduction [here](https://www.alibabacloud.com/help

		-> NOTE: Create instance or change instance would cost 10~15 minutes. Please make full preparation.

		-> NOTE: This resource is used to manage a Reserved Storage Mode instance, and creating new reserved storage mode instance is no longer supported.


		The following arguments are supported:

		* `engine` (Required) Database engine: `gpdb`.

Add new resource alicloud_gpdb_elastic_instance and no longer supports to create new alicloud_gpdb_instance resource #3727

Add new resource alicloud_gpdb_elastic_instance and no longer supports to create new alicloud_gpdb_instance resource #3727

Conversation

PrinceHenson commented Jul 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment