-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewResource alicloud_sae_ingress NewDataSource alicloud_sae_ingresses #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghx0991
reviewed
Aug 27, 2021
Wanghx0991
reviewed
Aug 27, 2021
thisnihonglei
force-pushed
the
ingress
branch
2 times, most recently
from
August 31, 2021 01:57
fd635b1
to
e79538f
Compare
Wanghx0991
reviewed
Aug 31, 2021
thisnihonglei
force-pushed
the
ingress
branch
from
September 13, 2021 03:32
e79538f
to
b73db73
Compare
Wanghx0991
reviewed
Sep 15, 2021
thisnihonglei
force-pushed
the
ingress
branch
4 times, most recently
from
September 15, 2021 08:15
a4b1bf6
to
bc746e2
Compare
thisnihonglei
force-pushed
the
ingress
branch
5 times, most recently
from
September 24, 2021 10:05
d48590e
to
4080f51
Compare
xiaozhu36
requested changes
Sep 24, 2021
} | ||
resp, err := jsonpath.Get("$.Data", response) | ||
if err != nil { | ||
return WrapErrorf(err, FailedGetAttributeMsg, action, "$.Data", response) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error 都应该是用 log.printf 打印出来,然后 return nil
thisnihonglei
force-pushed
the
ingress
branch
from
September 24, 2021 10:18
4080f51
to
e3418b7
Compare
thisnihonglei
force-pushed
the
ingress
branch
from
September 24, 2021 10:37
e3418b7
to
1fe69f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.