testcase: Adds a new test case for resource alicloud_nat_gateway #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozhu36
requested changes
Dec 3, 2021
| @@ -518,7 +518,7 @@ func resourceAlicloudNatGatewayDelete(d *schema.ResourceData, meta interface{}) | |||
| return nil | |||
| }) | |||
| if err != nil { | |||
| if IsExpectedErrors(err, []string{"INSTANCE_NOT_EXISTS", "IncorrectStatus.NatGateway", "InvalidNatGatewayId.NotFound", "InvalidRegionId.NotFound"}) { | |||
| if IsExpectedErrors(err, []string{"Forbidden.PrePaidNatGateway", "INSTANCE_NOT_EXISTS", "IncorrectStatus.NatGateway", "InvalidNatGatewayId.NotFound", "InvalidRegionId.NotFound"}) { | |||
thisnihonglei
force-pushed
the
natgateway
branch
3 times, most recently
from
6d168b6
to
8dda5d3
Compare
thisnihonglei
changed the title
thisnihonglei
force-pushed
the
natgateway
branch
3 times, most recently
from
9aea2d7
to
768cdae
Compare
xiaozhu36
requested changes
Dec 31, 2021
| @@ -18,7 +18,8 @@ If you want to add public IP, you can use resource 'alicloud_eip_association' to | |||
|
|
|||
| -> **NOTE:** From version 1.7.1, this resource has deprecated bandwidth packages. | |||
| But, in order to manage stock bandwidth packages, version 1.13.0 re-support configuring 'bandwidth_packages'. | |||
|
|
|||
|
|
|||
| -> **NOTE:** `PrePaid` VPC NAT Gateway cannot be destroyed and provider will remove it from the state file. | |||
There was a problem hiding this comment.
这个写清楚，当 payment_type 是 Subscription 或者 instance_charge_type 是prepaid 的时候是这样
thisnihonglei
force-pushed
the
natgateway
branch
from
768cdae
to
69577db
Compare
xiaozhu36
requested changes
Jan 5, 2022
| @@ -18,7 +18,8 @@ If you want to add public IP, you can use resource 'alicloud_eip_association' to | |||
|
|
|||
| -> **NOTE:** From version 1.7.1, this resource has deprecated bandwidth packages. | |||
| But, in order to manage stock bandwidth packages, version 1.13.0 re-support configuring 'bandwidth_packages'. | |||
|
|
|||
|
|
|||
| -> **NOTE:** The value of this attribute `payment_type` is `Subscription` or `Prepaid`, the VPC NAT Gateway cannot be destroyed and provider will remove it from the state file. | |||
There was a problem hiding this comment.
改成如下的内容，并且把如下的内容放在 ## Attributes Reference 上方
“### Deleting alicloud_nat_gateway or removing it from your configuration
The alicloud_nat_gateway resource allows you to manage payment_type = "Subscription" or instance_charge_type = "Prepaid" nat gateway, but Terraform cannot destroy it.
Deleting the subscription resource or removing it from your configuration
will remove it from your statefile and management, but will not destroy the Nat Gateway.
You can resume managing the subscription nat gateway via the AlibabaCloud Console. “
thisnihonglei
force-pushed
the
natgateway
branch
from
69577db
to
aa23700
Compare
thisnihonglei
force-pushed
the
natgateway
branch
from
aa23700
to
dde1ef1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.