Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase: Adds a new test case for resource alicloud_ecs_dedicated_host #4291

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

thisnihonglei
Copy link
Contributor

No description provided.

@thisnihonglei thisnihonglei changed the title resource/alicloud_ecs_dedicated_host: Add optional parameter verification testcase: Adds a new test case for resource alicloud_ecs_dedicated_host Dec 9, 2021
@@ -571,7 +571,7 @@ func resourceAlicloudEcsDedicatedHostDelete(d *schema.ResourceData, meta interfa
return nil
})
if err != nil {
if IsExpectedErrors(err, []string{"InvalidDedicatedHostId.NotFound"}) {
if IsExpectedErrors(err, []string{"ChargeTypeViolation", "InvalidDedicatedHostId.NotFound"}) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预付费的一样的处理逻辑

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改

ResourceName: resourceId,
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"auto_pay", "detail_fee", "dry_run", "auto_renew", "auto_renew_period", "expired_time"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

相比basic0,这个为啥有这么多ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basic0创建没用到auto_renew,auto_renew_period,expired_time这三个属性。这个用到了,然后跑单侧的时候发现不返回。我改了一下,basic0,1,2现在都统一了。不返回的用没用到都加在了ignore里

@xiaozhu36 xiaozhu36 merged commit e339d8d into aliyun:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants