resource/alicloud_pvtz_zone: Support update sync_status without user_info #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghx0991
force-pushed
the
pvtz_zone_added
branch
from
2b9478b
to
93eedd6
Compare
Wanghx0991
force-pushed
the
pvtz_zone_added
branch
from
93eedd6
to
8984aa6
Compare
Wanghx0991
commented
Dec 16, 2021
| conn, err := client.NewPvtzClient() | ||
| if err != nil { | ||
| return WrapError(err) | ||
| if _, ok := d.GetOk("user_info"); !ok { |
There was a problem hiding this comment.
客户提出应该与控制台功能保持一致, 配置同步任务变更, 应该自动更改, 所以需要查询一次
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "user_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "region_ids": { | ||
| Type: schema.TypeList, |
There was a problem hiding this comment.
客户做plan的时候发现了diff
There was a problem hiding this comment.
这个地方要打包测试下，看下List 和Set 是否相互兼容，我印象中是兼容的
xiaozhu36
requested changes
Dec 16, 2021
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "user_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "region_ids": { | ||
| Type: schema.TypeList, |
There was a problem hiding this comment.
这个地方要打包测试下，看下List 和Set 是否相互兼容，我印象中是兼容的
xiaozhu36
requested changes
Dec 17, 2021
| if IsExpectedErrors(err, []string{"MissingRegion"}) { | ||
| log.Printf("[DEBUG] Resource alicloud_private_zone_zone UpdateSyncEcsHostTask Missed Region!!! %s", err) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
这块还是因为之前说的,控制台通过status管理同步任务, 但Api里status,user_info这两个字段都应该是必填项, pvtz的做法是前端查出来自己填进去带给后端,这时会有几个情况:
- 用户创建资源未配置同步任务
- 用户创建资源没有配置同步任务, 但status置位了关闭状态(此时会有报错, 是预期中的错误)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.