Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alicloud_ess_scalingconfiguration: Adds new attributes spot_strategy and spot_price_limit #4413

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

TalentNing
Copy link
Contributor

=== RUN TestAccAlicloudEssScalingconfigurationsDataSource
--- PASS: TestAccAlicloudEssScalingconfigurationsDataSource (81.92s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 83.627s

=== RUN TestAccAlicloudEssScalingconfigurationsDataSource
--- PASS: TestAccAlicloudEssScalingconfigurationsDataSource (83.38s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 85.091s

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


tongkn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TalentNing TalentNing force-pushed the feat/ess_support_spotstrategy branch 2 times, most recently from 6929503 to c33233d Compare December 28, 2021 02:57
"spot_price_limit.0.price_limit": "2.1",
}),
),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要增加一个Update的测试步

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@TalentNing TalentNing force-pushed the feat/ess_support_spotstrategy branch from c33233d to bf38a52 Compare January 5, 2022 03:43
"spot_price_limit": {
Optional: true,
Type: schema.TypeList,
Elem: &schema.Resource{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在resource中应该改为 TypeSet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@TalentNing TalentNing force-pushed the feat/ess_support_spotstrategy branch 3 times, most recently from 250d975 to 7a00ed6 Compare January 6, 2022 11:53
},
"spot_price_limit": {
Type: schema.TypeSet,
Elem: &schema.Resource{
Copy link
Member

@xiaozhu36 xiaozhu36 Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在datesource 中应该是 TypeList,在resource中是 TypeSet

@TalentNing TalentNing force-pushed the feat/ess_support_spotstrategy branch from 7a00ed6 to f21bf07 Compare January 7, 2022 11:45
@TalentNing TalentNing force-pushed the feat/ess_support_spotstrategy branch from 31f7704 to a275b0f Compare January 7, 2022 12:17
@xiaozhu36 xiaozhu36 merged commit b2c782b into aliyun:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants