-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alicloud_ess_scalingconfiguration: Adds new attributes spot_strategy and spot_price_limit #4413
alicloud_ess_scalingconfiguration: Adds new attributes spot_strategy and spot_price_limit #4413
Conversation
tongkn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
6929503
to
c33233d
Compare
"spot_price_limit.0.price_limit": "2.1", | ||
}), | ||
), | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要增加一个Update的测试步
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
c33233d
to
bf38a52
Compare
"spot_price_limit": { | ||
Optional: true, | ||
Type: schema.TypeList, | ||
Elem: &schema.Resource{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在resource中应该改为 TypeSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
250d975
to
7a00ed6
Compare
}, | ||
"spot_price_limit": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Resource{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在datesource 中应该是 TypeList,在resource中是 TypeSet
7a00ed6
to
f21bf07
Compare
31f7704
to
a275b0f
Compare
=== RUN TestAccAlicloudEssScalingconfigurationsDataSource
--- PASS: TestAccAlicloudEssScalingconfigurationsDataSource (81.92s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 83.627s
=== RUN TestAccAlicloudEssScalingconfigurationsDataSource
--- PASS: TestAccAlicloudEssScalingconfigurationsDataSource (83.38s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 85.091s