resource/alicloud_ga_accelerator: Added the time limit of the field duration. #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghx0991
commented
Dec 29, 2021
| @@ -105,3 +115,329 @@ var AlicloudGaAcceleratorMap = map[string]string{ | |||
| func AlicloudGaAcceleratorBasicDependence(name string) string { | |||
| return "" | |||
| } | |||
|
|
|||
| func TestAccAlicloudGaAccelerator_unit(t *testing.T) { | |||
Wanghx0991
force-pushed
the
ga_fix
branch
6 times, most recently
from
3a175fd
to
ab7defc
Compare
xiaozhu36
requested changes
Dec 30, 2021
| request["Duration"] = duration | ||
| } else if duration > 9 && duration <= 36 { | ||
| request["PricingCycle"] = "Year" | ||
| request["Duration"] = duration / 12 |
Wanghx0991
force-pushed
the
ga_fix
branch
2 times, most recently
from
98b6e45
to
050ecf5
Compare
xiaozhu36
requested changes
Dec 30, 2021
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.StringInSlice([]string{"Month", "Year"}, false), | ||
| }, |
There was a problem hiding this comment.
这个属于非兼容变更，改成 optional，然后在代码中设置一个默认值 Month，这个设置为 Computed
Wanghx0991
force-pushed
the
ga_fix
branch
5 times, most recently
from
661664b
to
3a93fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.