testcase: Improve the effectiveness of test cases #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghx0991
commented
Jan 25, 2022
| @@ -86,18 +86,18 @@ func TestAccAlicloudECIOpenAPIImageCache_basic(t *testing.T) { | |||
| { | |||
| Config: testAccConfig(map[string]interface{}{ | |||
| "image_cache_name": strings.ToLower(name), | |||
| "images": []string{"registry.cn-beijing.aliyuncs.com/sceneplatform/sae-image-demo:latest"}, | |||
scripts/schema_test.go
Outdated
| fileter_list = make(map[string][]string, 0) | ||
| // map[resourceName][]string{WhiteField} | ||
| filterList = map[string][]string{ | ||
| "alicloud_amqp_instance":[]string{"logistics"}, |
There was a problem hiding this comment.
这块加了下白名单, 填入的不再做校验了
Wanghx0991
force-pushed
the
test_fix
branch
8 times, most recently
from
f1d146e
to
a1057ef
Compare
Wanghx0991
commented
Jan 26, 2022
| ioutil.WriteFile(file.(string), []byte(response["PrivateKeyBody"].(string)), 0600) | ||
| os.Chmod(file.(string), 0400) | ||
| if v, exist := response["PrivateKeyBody"]; exist { | ||
| err := ioutil.WriteFile(file.(string), []byte(v.(string)), 0600) |
There was a problem hiding this comment.
这里的err需要处理 否则CI没有通过
| @@ -171,7 +171,7 @@ func resourceAliyunEipAssociationDelete(d *schema.ResourceData, meta interface{} | |||
| }) | |||
| if err != nil { | |||
| if IsExpectedErrors(err, []string{"IncorrectInstanceStatus", "IncorrectHaVipStatus", "TaskConflict", | |||
| "InvalidIpStatus.HasBeenUsedBySnatTable", "InvalidIpStatus.HasBeenUsedByForwardEntry"}) { | |||
| "InvalidIpStatus.HasBeenUsedBySnatTable", "InvalidIpStatus.HasBeenUsedByForwardEntry", "InvalidStatus.EniStatusNotSupport"}) { | |||
There was a problem hiding this comment.
值班的一个问题 删除报错 需要重试
xiaozhu36
requested changes
Jan 26, 2022
scripts/schema_test.go
Outdated
| @@ -34,7 +34,10 @@ func init() { | |||
| var ( | |||
| resourceName = flag.String("resource", "", "the name of the terraform resource to diff") | |||
| fileName = flag.String("file_name", "", "the file to check diff") | |||
| fileter_list = make(map[string][]string, 0) | |||
| // map[resourceName][]string{WhiteField} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.