resource/pvtz_rule: add the query field bind_vpcs resource/alb_load_balancer: add the query field dns_name #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghx0991
changed the title
xiaozhu36
requested changes
Feb 24, 2022
| "dns_name": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
这不应该加在resource上，应该加在datasource上
| @@ -59,6 +59,22 @@ func resourceAlicloudPvtzRule() *schema.Resource { | |||
| Required: true, | |||
| ForceNew: true, | |||
| }, | |||
| "bind_vpcs": { | |||
There was a problem hiding this comment.
这个不应该直接加成一个属性，应该用一个attachment资源
Wanghx0991
force-pushed
the
ecs_fix
branch
3 times, most recently
from
80ca8c6
to
b9cd8c8
Compare
…alancer: add the query field dns_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.