New Resource: alicloud_ddos_basic_defense_threshold #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaozhu36
requested changes
May 18, 2022
| State: schema.ImportStatePassthrough, | ||
| }, | ||
| Schema: map[string]*schema.Schema{ | ||
| "ddos_region_id": { |
There was a problem hiding this comment.
这个regionid 没必要写啊，这个是跟实例的所在的region是一样的，直接使用 provider中的region就行
| } | ||
|
|
||
| `, name) | ||
| } |
| @@ -0,0 +1,230 @@ | |||
| package alicloud | |||
There was a problem hiding this comment.
这个资源的名字不对吧，既然用的是 ModifyDefenseThreshold，那么把 antiddos 改成 defense_threshold
Wanghx0991
force-pushed
the
antiddos
branch
3 times, most recently
from
f36e263
to
d19c22f
Compare
Wanghx0991
changed the title
Wanghx0991
force-pushed
the
antiddos
branch
2 times, most recently
from
a45fec6
to
071a3d9
Compare
xiaozhu36
requested changes
May 20, 2022
| `, name) | ||
| } | ||
|
|
||
| func TestAccAlicloudDdosBasicDefenseThreshold_unit(t *testing.T) { |
There was a problem hiding this comment.
单元测试的标题都改为 TestUnitAlicloudxxx 了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.