resource/alicloud_quotas_quota_alarm: Support for international languages. #7035
Conversation
alicloud/connectivity/client.go
Outdated
| "AcceptLanguage": tea.String("en-US"), | ||
| } | ||
| param := &openapi.GlobalParameters{Queries: query} | ||
| config := &openapi.Config{ |
There was a problem hiding this comment.
config 的构造抽成一个独立的方法，所有的 Client 都是共用的
包括上面的 query
| @@ -128,7 +131,7 @@ func resourceAliCloudQuotasQuotaAlarmCreate(d *schema.ResourceData, meta interfa | |||
| } | |||
| wait := incrementalWait(3*time.Second, 5*time.Second) | |||
| err = resource.Retry(d.Timeout(schema.TimeoutCreate), func() *resource.RetryError { | |||
| response, err = conn.DoRequest(StringPointer(action), nil, StringPointer("POST"), StringPointer("2020-05-10"), StringPointer("AK"), nil, request, &util.RuntimeOptions{}) | |||
| response, err = conn.CallApi(genRpcParam(action, "POST", "2020-05-10"), &openapi.OpenApiRequest{Query: query, Body: request, HostMap: hostMap}, &util.RuntimeOptions{}) | |||
There was a problem hiding this comment.
POST 最好也直接用方法名来表达掉，rpcPostParam(action, "2020-05-10"))
There was a problem hiding this comment.
hostMap 是干啥的？如果都是所有调用公用的，是不是也可以封装掉，我理解这个地方就只有Query和Body 两个参数，是不是可以用顺序来指定这两个参数。
另外，如果其中一个参数没有被用到，是不是可以不初始化，直接 nil 就可以
There was a problem hiding this comment.
有极少部分产品的参数会放到host上，如果没使用的话用nil即可
There was a problem hiding this comment.
POST 最好也直接用方法名来表达掉，rpcPostParam(action, "2020-05-10"))
这个method可能为GET，当参数更合适一些吧
alicloud/common.go
Outdated
| @@ -1633,6 +1633,20 @@ func genRoaParam(action, method, version, path string) *openapi.Params { | |||
| } | |||
| } | |||
|
|
|||
| func genRpcParam(action, method, version string) *openapi.Params { | |||
ChenHanZhang
force-pushed
the
QuotaLanguage
branch
2 times, most recently
from
9c44ce7
to
573385c
Compare
alicloud/connectivity/client.go
Outdated
|
|
||
| openapiConfig.Endpoint = tea.String(endpoint) | ||
| _result := &openapi.Client{} | ||
| _result, _err := openapi.NewClient(&openapiConfig) |
There was a problem hiding this comment.
sdk 官网给的example，这里我优化下
| Pathname: tea.String("/"), | ||
| Method: tea.String(method), | ||
| AuthType: tea.String("AK"), | ||
| Style: tea.String("RPC"), |
There was a problem hiding this comment.
不是说不区分 rpc 和 roa 了么？是不是可以统一掉了
alicloud/connectivity/config.go
Outdated
| //} | ||
| //if c.SecureTransport != "" { | ||
| // config.SetSecureTransport(c.SecureTransport) | ||
| //} |
There was a problem hiding this comment.
这两个如果确定不需要了或者挪到header 中了，那么这个地方就去掉吧，另外需要测试确认下自定义的 header 确实可以设置成功
There was a problem hiding this comment.
这里就和具体的产品api风格有关了，放到client下进行设置
ChenHanZhang
force-pushed
the
QuotaLanguage
branch
2 times, most recently
from
78211eb
to
068fefc
Compare
ChenHanZhang
force-pushed
the
QuotaLanguage
branch
from
068fefc
to
62c5f32
Compare
No description provided.