Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_ess_eci_scaling_configuration: add instance_types. #7171

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

fuliu-zln
Copy link
Contributor

…nd upgrade api version

@fuliu-zln fuliu-zln force-pushed the feat/support_instanceTypes branch 5 times, most recently from a18ccbb to 2d7cf94 Compare April 24, 2024 02:48
@fuliu-zln fuliu-zln changed the title resource/alicloud_ess_eci_scaling_configuration: add instance_types and upgrade api version. resource/alicloud_ess_eci_scaling_configuration: add instance_types. Apr 24, 2024
@fuliu-zln fuliu-zln force-pushed the feat/support_instanceTypes branch 2 times, most recently from 5e3b54c to bd7eefd Compare April 24, 2024 03:42
Optional: true,
Elem: &schema.Schema{
Type: schema.TypeString,
MaxItems: 5,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测一下是否会乱序,用例里三个item,测试两个部分交互item顺序

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@fuliu-zln fuliu-zln force-pushed the feat/support_instanceTypes branch 5 times, most recently from 6dc1bf2 to 817456b Compare April 28, 2024 02:24
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ChenHanZhang ChenHanZhang merged commit eedd38d into aliyun:master Apr 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants