Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_cs_managed_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_edge_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_serverless_kubernetes: output error message when failed to upgrade cluster #7248

Merged
merged 1 commit into from
May 17, 2024

Conversation

sanyangji
Copy link
Contributor

No description provided.

@sanyangji sanyangji changed the title resource/alicloud_cs_managed_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_edge_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_serveless_kubernetes: output error message when failed to upgrade cluster resource/alicloud_cs_managed_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_edge_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_serverless_kubernetes: output error message when failed to upgrade cluster May 15, 2024
@sanyangji sanyangji force-pushed the expose-errmsg branch 2 times, most recently from d4854e5 to 5fa59cf Compare May 15, 2024 05:47
@@ -675,7 +675,7 @@ func resourceAlicloudCSEdgeKubernetesUpdate(d *schema.ResourceData, meta interfa
// upgrade cluster version
err := UpgradeAlicloudKubernetesCluster(d, meta)
if err != nil {
return WrapErrorf(err, DefaultErrorMsg, d.Id(), "UpgradeClusterVersion", DenverdinoAliyungo)
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个为啥要改

UpgradeAlicloudKubernetesCluster(d, meta)
err := UpgradeAlicloudKubernetesCluster(d, meta)
if err != nil {
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加上 wraperror

@@ -546,7 +546,7 @@ func resourceAlicloudCSServerlessKubernetesUpdate(d *schema.ResourceData, meta i
// upgrade cluster version
err := UpgradeAlicloudKubernetesCluster(d, meta)
if err != nil {
return WrapErrorf(err, DefaultErrorMsg, d.Id(), "UpgradeClusterVersion", DenverdinoAliyungo)
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这个

@sanyangji sanyangji force-pushed the expose-errmsg branch 3 times, most recently from ebb9e8a to 654ed2e Compare May 16, 2024 08:56
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

…iled to upgrade cluster;resource/alicloud_cs_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_edge_kubernetes: output error message when failed to upgrade cluster;resource/alicloud_cs_serverless_kubernetes: output error message when failed to upgrade cluster
@sanyangji
Copy link
Contributor Author

resource_alicloud_cs_edge_kubernetes测试结果:
=== RUN TestAccAliCloudEdgeKubernetes
--- PASS: TestAccAliCloudEdgeKubernetes (2392.77s)
=== RUN TestAccAliCloudEdgeKubernetes_essd
provider_test.go:154: Skipping unsupported region eu-central-1. Supported regions: [cn-zhangjiakou cn-huhehaote].
--- SKIP: TestAccAliCloudEdgeKubernetes_essd (0.00s)
=== RUN TestAccAliCloudEdgeKubernetes_pro
--- PASS: TestAccAliCloudEdgeKubernetes_pro (989.31s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 3384.207s

@ChenHanZhang ChenHanZhang merged commit d0ef4a1 into aliyun:master May 17, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants