-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/alicloud_kms_key: Added the field policy; Improved alicloud_kms_key testcase #7251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
@@ -37,7 +37,7 @@ func init() { | |||
func testSweepKmsKey(region string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TF_ACC=1 go test ./alicloud -v -run=TestAccAliCloudKmsKey_basic0 -timeout=1200m
=== RUN TestAccAliCloudKmsKey_basic0
--- PASS: TestAccAliCloudKmsKey_basic0 (55.24s)
=== RUN TestAccAliCloudKmsKey_basic0_twin
--- PASS: TestAccAliCloudKmsKey_basic0_twin (7.12s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 62.445s
TF_ACC=1 go test ./alicloud -v -run=TestAccAliCloudKmsKey_basic1 -timeout=1200m
=== RUN TestAccAliCloudKmsKey_basic1
--- PASS: TestAccAliCloudKmsKey_basic1 (366.46s)
=== RUN TestAccAliCloudKmsKey_basic1_twin
--- PASS: TestAccAliCloudKmsKey_basic1_twin (246.37s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 612.941s
TF_ACC=1 go test ./alicloud -v -run=TestAccAliCloudKmsKey_basic2 -timeout=1200m
=== RUN TestAccAliCloudKmsKey_basic2
--- PASS: TestAccAliCloudKmsKey_basic2 (56.10s)
=== RUN TestAccAliCloudKmsKey_basic2_twin
--- PASS: TestAccAliCloudKmsKey_basic2_twin (7.59s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 63.781s
TF_ACC=1 go test ./alicloud -v -run=TestAccAliCloudKmsKey_basic3 -timeout=1200m
=== RUN TestAccAliCloudKmsKey_basic3
--- PASS: TestAccAliCloudKmsKey_basic3 (54.53s)
=== RUN TestAccAliCloudKmsKey_basic3_twin
--- PASS: TestAccAliCloudKmsKey_basic3_twin (7.58s)
PASS
ok github.com/aliyun/terraform-provider-alicloud/alicloud 62.186s
Finish!
}, | ||
"pending_window_in_days": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的Computed得看下后端会不会返回
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending_window_in_days只有在删除的时候才会被使用,查询接口无法返回,也没有set
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个Computed也得看下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个字段如果是二选一,其中一个设置值的话,另一个未设置值也会读到值吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不会,没有查询接口,没有set,所以这两个字段都没值
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
No description provided.