Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] /images/json API isn't compatible with Moby #76

Closed
allencloud opened this issue Nov 9, 2017 · 1 comment
Closed

[bug report] /images/json API isn't compatible with Moby #76

allencloud opened this issue Nov 9, 2017 · 1 comment
Assignees
Labels
areas/api kind/bug This is bug report for project

Comments

@allencloud
Copy link
Collaborator

allencloud commented Nov 9, 2017

Issue Description
In the existing API of Pouch, /images/json API isn't compatible with Moby.
File https://github.com/alibaba/pouch/blob/master/apis/types/image_info.go is redundant, and should use https://github.com/alibaba/pouch/blob/master/apis/types/image_summary.go.

Pouch used containerd 1.0.0, and image details are from containerd side. https://github.com/alibaba/pouch/blob/master/apis/types/image_info.go is for containerd, while I think we need to transform that into Moby's API.

Discussed with @Ace-Tang offline, this needs updated. Maybe we can refer to moby/moby#34895, since this PR merged containerd 1.0.0 with moby.

Describe what happened:
NONE

Describe what you expected to happen:
NONE

How to reproduce it (as minimally and precisely as possible):
NONE

Anything else we need to know?:
NONE

Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Nov 9, 2017
@allencloud
Copy link
Collaborator Author

Any update on this one? @Ace-Tang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/api kind/bug This is bug report for project
Projects
None yet
Development

No branches or pull requests

3 participants