Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OT199-47-Endpoint-CreateNews #54

Merged
merged 14 commits into from May 30, 2022
Merged

OT199-47-Endpoint-CreateNews #54

merged 14 commits into from May 30, 2022

Conversation

Miguelch7
Copy link
Collaborator

  • Se creó el router de news
  • Se creó el endpoint POST /news
  • Se valida la existencia de los campos
  • Se valida que el usuario sea Admin
  • Se valida que el categoryId exista
  • Se retorna la news creada
  • Se modificó el modelo, creando el campo "type"

soyarielruiz
soyarielruiz reviewed May 30, 2022
View reviewed changes
controllers/newsController.js Outdated Show resolved Hide resolved
helpers/validator.js Outdated Show resolved Hide resolved
@Miguelch7
Copy link
Collaborator Author

  • Se removió la validación del CategoryId
  • Se añadió el mensaje a la respuesta y se envia directamente la news

soyarielruiz
soyarielruiz approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@soyarielruiz soyarielruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolver conflictos y mergear.

@Miguelch7 Miguelch7 merged commit 20ea507 into development May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyarielruiz soyarielruiz soyarielruiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Miguelch7 @soyarielruiz