Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make all-contributors output Prettier compliant. #283

Merged
merged 1 commit into from Sep 16, 2020
Merged

fix: make all-contributors output Prettier compliant. #283

merged 1 commit into from Sep 16, 2020

Conversation

melink14
Copy link
Contributor

@melink14 melink14 commented Sep 12, 2020

What:
Fixes all-contributors/all-contributors#441 by inserting a newline after the prettier-ignore-end.

Why:

Without this fix, manual changes are required to all-contributors-cli output to ensure prettier check doesn't fail.

How:

Added a single \n and updated the tests.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@Berkmann18 Berkmann18 changed the title fix: Make all-contributors output Prettier compliant. fix: make all-contributors output Prettier compliant. Sep 16, 2020
@Berkmann18 Berkmann18 merged commit 1affe41 into all-contributors:master Sep 16, 2020
@Berkmann18
Copy link
Member

@all-contributors Please add @melink14 for bug fix

@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @melink14! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier and All Contributors conflicting
3 participants