Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonyms #274

Closed
krzkaczor opened this issue May 24, 2019 · 5 comments
Closed

Synonyms #274

krzkaczor opened this issue May 24, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@krzkaczor
Copy link

Is your feature request related to a problem? Please describe.
I tried adding new contributos for idea and docs but the proper terms where ideas and doc.

Describe the solution you'd like
Solution is to allow synonyms for contribution types. Probably bot, or CLI should always normalize to one form but user interface should be as simple as possible.

@krzkaczor krzkaczor added the enhancement New feature or request label May 24, 2019
@Berkmann18
Copy link
Member

The bot already supports synonyms and such. The CLI will point out when you're not using the correct terms; at the same time it has prompts which allow you to specify the username and contributions.

@krzkaczor
Copy link
Author

My experience was that CLI was just ignoring them:

all-contributors add someone code idea

but now i realized that it was because CLI takes only one argument 🤦‍♂ my fault. Nvm.

I think if synonyms are supported this should be noted in https://allcontributors.org/docs/en/emoji-key

@Berkmann18
Copy link
Member

@krzkaczor The CLI takes more than one argument unless you're using check, generate or the upcoming fetch one.

I think if synonyms are supported this should be noted in https://allcontributors.org/docs/en/emoji-key

That's the general emoji-key which don't have the variations (what I meant when I wrote about the bot supporting synonyms) and having synonyms in the spec would make the whole thing unnecessarily complex (especially in areas where there's NO NLP/ML).

@Berkmann18
Copy link
Member

@krzkaczor Is this still a problem?

@krzkaczor
Copy link
Author

yeah i think I ll just close this ;) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants