-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a contributor without creating an issue / comment #149
Comments
Could the bot support more types of webhooks? This would require the external services to have some sort of trigger option available, but could be a step in the right direction. Doesn't look like Open Collective has webhooks available for donations, but they do have a custom redirect option. You could set the redirect url in OC to point to the bot. The bot would grab the transaction id from the url, invoke a lambda to handle making a PR based on the transaction, and then redirect the user again to the final destination. |
I think I’d leave the integration between Open Collective and all-contributors to the maintainers, I wouldn’t assume that everyone would want to list financial backers as contributors, too. The app is built with Probot, and Probot can expose custom routes to receive whatever we want. It can also serve custom UIs |
Sorry, thought you were a maintainer since you added the label to this issue. Now I see it's part of the issue template. |
@gr2m The custom UI idea seems good to me. As for the backer listing as financial contributors, that's something we are okay with and I believe @jakebolam mentioned nock about that backer -> financial contributor change. In any case, feel free (@chadfawcett same goes for you) to open a PR for that. |
@gr2m greetings, looks like I can start the UI for this one since this will have almost the same implementation |
Sure, go ahead 👍🏼 |
Is your feature request related to a problem? Please describe.
A new backer joined nock’s open collective, there are is no issue or pull request on the repository I could comment on.
Describe the solution you'd like
I wonder if the app could provide a custom UI to add a new contributor. E.g. there could be something like https://app.allcontributors.org/add-contributor with an OAuth authentication flow and a form that matches the current comment syntax to add a new contributor
Describe alternatives you've considered
I’ve created a new issue which is a decent alternative: I created one here:
nock/nock#1461
One thing that would be cool is if the pull request created for the new issue would include
closes #123
I added it manually now
nock/nock#1462
The text was updated successfully, but these errors were encountered: