Doesn't recognize hyphens in a user's name (at the end of their name)?

[jpivarski]

See scikit-hep/awkward#238

I attempted to add @nsmith- (name ends in a hyphen) and it didn't work the first time (don't know why), but a trivial change in the list of roles (removed Oxford comma) caused the bot to add @nsmith without a hyphen.

I'm now editing the pull request by hand.

[baikho]

Hi @jpivarski,
I believe this is a duplicate of #292 and PR #307 . Do we need to tag a new release for these changes to take effect @Berkmann18 ?

[Berkmann18]

@baikho Normally no, as it's done automatically.
I noticed your PR didn't get a response from the release bot which makes me wonder what went wrong.

[rkdarst]

I just got hit with this: I used the bot to add a contributor with github login firstname-lastname, and the bot added firstname (a different person) as a contributor! rkdarst/all-contributors-test#2

[reobin]

Seems like this is still an issue, even when using the @ before the user name

Link

[Berkmann18]

That seems to be due to the fact that the CI/CD pipeline didn't work on the @baikho's PR and I don't have admin rights there so I can't see exactly what went wrong.

[Berkmann18]

@jpivarski The bot was rewritten and we've got a better logging system now, could you try again and we'll see if it's still an issue?

[tenshiAMD]

@jpivarski The bot was rewritten and we've got a better logging system now, could you try again and we'll see if it's still an issue?

@jpivarski Have you check this using latest version? Please check and let us know if this still occurs. Closing this for now. Thanks! 🎉