Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor profile url need to be validated #267

Closed
k3nsei opened this issue Jun 5, 2020 · 2 comments · Fixed by #268
Closed

Contributor profile url need to be validated #267

k3nsei opened this issue Jun 5, 2020 · 2 comments · Fixed by #268
Labels
enhancement status: available
Projects
All Contributors Kanban

Comments

@k3nsei
Copy link
Contributor

k3nsei commented Jun 5, 2020 •
edited
Loading

  • all-contributors-cli version: 6.15.0
  • node version: 14.2.0
  • npm (or yarn) version: 1.22.4

What you did:

yarn run all-contributors add Silvest89
yarn run all-contributors generate

What happened:

Silvest89 has some string instead of url. So after generation of contributors template. Code was invalid html.

Suggested solution:

Please validate if url in github profile if it is valid url. If it isn't please use url to github profile.
@Berkmann18
Copy link
Member

Hmm, that definitely shouldn't happen, feel free to submit a PR for this.

@Berkmann18 Berkmann18 added this to To do in All Contributors Kanban via automation Jun 6, 2020
@k3nsei k3nsei mentioned this issue Jun 7, 2020
Merged
3 tasks
@k3nsei
Copy link
Contributor Author

k3nsei commented Jun 7, 2020

@Berkmann18 sure will do

@Berkmann18 Berkmann18 linked a pull request Jun 7, 2020 that will close this issue
feat(repo): github profile url should be valid #268
Merged
3 tasks
All Contributors Kanban automation moved this from To do to Done Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status: available
Projects
No open projects
All Contributors Kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(repo): github profile url should be valid
2 participants
@k3nsei @Berkmann18